Fix potential crash on windows if raw.FileNameLength exceeds syscall.MAX_PATH#361
Merged
Merged
Fix potential crash on windows if raw.FileNameLength exceeds syscall.MAX_PATH#361
Conversation
mattn
reviewed
Jan 15, 2022
mattn
approved these changes
Jan 26, 2022
Contributor
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Fix #318.
Where should the reviewer start?
How should this be manually tested?
The crash only happens when we enable recursive watch on windows here: https://github.com/fsnotify/fsnotify/blob/master/windows.go#L350 by changing the argument flag from false to true.
Then if we create a really long filepath (see code snippet in #318), and begin watching on the first parent directory of that path and let the recursive watch propagates, fsnotify will crash.