Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[App Check] Add AppAttestProviderFactory#16182

Merged
ncooke3 merged 5 commits into
mainfirebase/firebase-ios-sdk:mainfrom
ah/app-attest-factoryfirebase/firebase-ios-sdk:ah/app-attest-factoryCopy head branch name to clipboard
May 19, 2026
Merged

[App Check] Add AppAttestProviderFactory#16182
ncooke3 merged 5 commits into
mainfirebase/firebase-ios-sdk:mainfrom
ah/app-attest-factoryfirebase/firebase-ios-sdk:ah/app-attest-factoryCopy head branch name to clipboard

Conversation

@andrewheard

@andrewheard andrewheard commented May 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Added a built-in AppAttestProviderFactory so that developers don't need to manually create one. From the documentation, this simplifies

class YourSimpleAppCheckProviderFactory: NSObject, AppCheckProviderFactory {
  func createProvider(with app: FirebaseApp) -> AppCheckProvider? {
    return AppAttestProvider(app: app)
  }
}

AppCheck.setAppCheckProviderFactory(YourAppCheckProviderFactory())

to

AppCheck.setAppCheckProviderFactory(AppAttestProviderFactory())

@gemini-code-assist

gemini-code-assist Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@andrewheard

andrewheard commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

/gemini summary

@gemini-code-assist

gemini-code-assist Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

This pull request simplifies the integration of App Attest with Firebase App Check by providing a ready-to-use factory class. By replacing the need for developers to manually implement a custom AppCheckProviderFactory, the setup process is significantly reduced to a single line of code, improving developer experience and reducing boilerplate.

Highlights

  • New Factory Class: Introduced AppAttestProviderFactory to provide a built-in implementation for App Attest, simplifying the App Check setup process for developers.
  • API Exposure: Exposed the new factory class in the public headers to ensure it is accessible for library consumers.
  • Testing and Verification: Added unit tests to verify the factory's functionality and updated the test target dependencies in Package.swift.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Activity
  • Pull request created by andrewheard.
  • Gemini Code Assist bot provided usage instructions.
  • Author requested a summary of the pull request.

@andrewheard andrewheard added this to the 12.14.0 - M181 milestone May 15, 2026
@ncooke3 ncooke3 self-assigned this May 18, 2026
@ncooke3
ncooke3 marked this pull request as ready for review May 19, 2026 16:00
@ncooke3
ncooke3 requested a review from a team as a code owner May 19, 2026 16:00
@ncooke3

ncooke3 commented May 19, 2026

Copy link
Copy Markdown
Member

API proposal approved.

@ncooke3
ncooke3 enabled auto-merge (squash) May 19, 2026 16:01
@ncooke3
ncooke3 disabled auto-merge May 19, 2026 16:01
@ncooke3
ncooke3 merged commit 89ac23e into main May 19, 2026
141 of 149 checks passed
@ncooke3
ncooke3 deleted the ah/app-attest-factory branch May 19, 2026 16:02
@github-actions github-actions Bot mentioned this pull request May 27, 2026
Merged
leojaygoogle pushed a commit that referenced this pull request Jun 29, 2026
@andrewheard @ncooke3 @leojaygoogle
[App Check] Add AppAttestProviderFactory (#16182)
484038e 
Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees

@ncooke3 ncooke3

Labels

api: appcheck public-api-change

Projects

None yet

Milestone

12.14.0 - M181

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewheard @ncooke3
Morty Proxy This is a proxified and sanitized view of the page, visit original site.