[AI] Finish Reasons by paulb777 · Pull Request #15931 · firebase/firebase-ios-sdk

paulb777 · Mar 11, 2026

PR Review: [AI] Finish Reasons #15931

This pull request, [AI] Finish Reasons #15931, introduces support for expanded FinishReason values and a new finishMessage property within the FirebaseAI SDK. These changes aim to provide more granular feedback when the model stops generating content, particularly for image generation and tool-use scenarios.

Key Changes

1. Enhanced Model Response Metadata

New Property: Added finishMessage to the Candidate struct. This is a human-readable string explaining why the model stopped generating.
Expanded Enums: The FinishReason enum now includes several new cases:
- Image-Related: imageSafety, imageProhibitedContent, imageOther, noImage, and imageRecitation.
- Tool & Logic: unexpectedToolCall, tooManyToolCalls, missingThoughtSignature, and malformedResponse.
- General: language (for unsupported languages).

2. Testing and Validation

Integration Tests: Added a new test generateContent_finishReason_imageSafety to verify that prompts triggering safety violations (e.g., "A graphic image of violence") correctly return the expected imageSafety or noImage reasons.
Unit Tests: * Added decoding tests to ensure all new FinishReason strings from the API are mapped correctly.
- Updated isEmpty logic to ensure a candidate is not considered empty if it contains a finishMessage.

3. Documentation

Updated the CHANGELOG.md to reflect these new features, noting the added support for image generation safety reasons and tool-use feedback.

…e-config

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

gemini-code-assist · Mar 11, 2026

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

paulb777 · Mar 11, 2026

/gemini review

gemini-code-assist

Code Review

This pull request adds several new FinishReason cases, primarily related to image generation and tool usage, and includes corresponding integration tests. The changes are generally good, but I've identified a minor grammatical error in a documentation comment and a more significant issue in one of the new integration tests. The test for Imagen safety filtering is incorrectly structured and will fail as it doesn't account for an expected error being thrown. I've provided a corrected implementation for the test.

paulb777 · Mar 11, 2026

/gemini review

gemini-code-assist

Code Review

This pull request adds several new FinishReason cases to the SDK, along with corresponding unit and integration tests. The changes to the FinishReason enum and the new integration test for Gemini models are well-implemented. However, I've identified a logical issue in the new Imagen integration test and an opportunity to improve maintainability in the new unit test for decoding finish reasons. My detailed feedback is in the comments below.

paulb777 · Mar 12, 2026

/gemini review

gemini-code-assist

Code Review

This pull request adds several new FinishReason cases to handle more scenarios, particularly around image generation and tool calls. The changes include updating the FinishReason enum and its corresponding static properties. New unit tests are added to verify the decoding of these new reasons, and a new integration test is introduced to check the imageSafety finish reason. The changes are well-implemented and tested. I have one minor suggestion to improve the new unit test's maintainability.

paulb777 · Apr 24, 2026

Integration test failures look like flakes

daymxn

LGTM, cc'd andrew incase he wants to double check

note: Integ test failures do seem to be flakes, as paul mentioned above

andrewheard

I did a super quick pass and LGTM. Just noticed the one changelog entry issue.

Co-authored-by: Andrew Heard <andrewheard@google.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Daymon <17409137+daymxn@users.noreply.github.com> Co-authored-by: Daymon <daymxn@google.com>

andrewheard and others added 20 commits March 10, 2026 16:00

[AI] Add config for image aspect ratio and size with Nano Banana

26f0784

Merge remote-tracking branch 'origin/ah/ai-image-config' into pb-imag…

9d6081e

…e-config

build issues

07e45e5

Add available annotations

2005fea

docs, agents, and more tests

918fcf3

integration tests

879fa39

Add missing default value imageSize: ImagenImageSize? = nil

7ac3ae3

Fix tests

a1c1006

Address TODOs

30405c2

More build fixes

3e2736a

review

e88c0de

Merge remote-tracking branch 'origin/ah/ai-image-config' into pb-imag…

bd09d10

…e-config

Apply suggestions from code review

36068b9

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

review, style

eccd2c8

style

a663da0

Replace custom Encodable conformance with EncodableProtoEnum

5f37627

Check sizes in image generation tests

36a9828

Add image generation size integration test

5ca0094

Add TODO for Imagen integration test

bc1d717

Add imagen image_size integration test

b8107c3

gemini-code-assist Bot reviewed Mar 11, 2026

View reviewed changes

Comment thread FirebaseAI/Tests/TestApp/Tests/Integration/ImagenIntegrationTests.swift Outdated

Comment thread FirebaseAI/Sources/GenerateContentResponse.swift Outdated

danger-firebase-ios Bot added the api: firebaseai label Mar 11, 2026

gemini-code-assist Bot reviewed Mar 11, 2026

View reviewed changes

Comment thread FirebaseAI/Tests/TestApp/Tests/Integration/ImagenIntegrationTests.swift Outdated

Comment thread FirebaseAI/Tests/Unit/APITests.swift

gemini-code-assist Bot reviewed Mar 12, 2026

View reviewed changes

Comment thread FirebaseAI/Tests/Unit/APITests.swift

paulb777 added 2 commits March 13, 2026 16:01

Merge remote-tracking branch 'origin/main' into pb-image-config

a433717

post-merge availability cleanup

268800c

paulb777 force-pushed the pb-finish-reason branch from 1a6b378 to c6df95a Compare April 13, 2026 20:48

daymxn reviewed Apr 23, 2026

View reviewed changes

Comment thread FirebaseAI/Sources/GenerateContentResponse.swift

paulb777 added 2 commits April 24, 2026 09:31

Merge branch 'main' into pb-image-config

ee987f5

review

77cd85d

paulb777 force-pushed the pb-finish-reason branch from c6df95a to ed81ec3 Compare April 24, 2026 16:52

paulb777 marked this pull request as ready for review April 24, 2026 16:52

paulb777 added 6 commits April 24, 2026 10:06

fix merge botch

f4c9c70

[AI] Finish Reasons

ad7d5c7

Fix tests

abefac7

review and remove unnecessary flaky test

4d8cd07

review and changelog

3a69994

finish message

7573ed6

paulb777 force-pushed the pb-finish-reason branch from ed81ec3 to 7573ed6 Compare April 24, 2026 17:07

paulb777 requested a review from daymxn April 24, 2026 18:47

daymxn requested a review from andrewheard April 27, 2026 20:10

daymxn approved these changes Apr 27, 2026

View reviewed changes

andrewheard approved these changes Apr 28, 2026

View reviewed changes

Comment thread FirebaseAI/CHANGELOG.md

Add back missing changelog entry

6014d6f

Base automatically changed from pb-image-config to main April 28, 2026 19:04

daymxn requested a review from a team as a code owner April 28, 2026 19:04

Merge branch 'main' into pb-finish-reason

7343c3f

daymxn enabled auto-merge (squash) April 28, 2026 19:08

daymxn disabled auto-merge April 28, 2026 19:08

daymxn enabled auto-merge (squash) April 28, 2026 19:08

daymxn merged commit d2ef47c into main Apr 28, 2026
29 checks passed

daymxn deleted the pb-finish-reason branch April 28, 2026 19:09

github-actions Bot mentioned this pull request May 6, 2026

Update to Firebase 12.13.0 afresh-technologies/firebase-ios-sdk-xcframeworks#108

Merged

coderabbitai Bot mentioned this pull request May 28, 2026

Update dependencies and add new firebase-ai APIs uny/firebase-kotlin-sdk#49

Merged

4 tasks

Search code, repositories, users, issues, pull requests...

Uh oh!

Conversation

paulb777 commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review: [AI] Finish Reasons #15931

Key Changes

1. Enhanced Model Response Metadata

2. Testing and Validation

3. Documentation

Uh oh!

gemini-code-assist Bot commented Mar 11, 2026

Uh oh!

paulb777 commented Mar 11, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

paulb777 commented Mar 11, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

paulb777 commented Mar 12, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

paulb777 commented Apr 24, 2026

Uh oh!

daymxn left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andrewheard left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

paulb777 commented Mar 11, 2026 •

edited

Loading

daymxn left a comment •

edited

Loading