fix(core): accept boolean attributes in headTags config validation by DhineshPonnarasan · Pull Request #12238 · facebook/docusaurus

DhineshPonnarasan · Jul 7, 2026

Summary

The headTags config validation rejects boolean HTML attribute values like async: true, even though the TypeScript types and renderer already support them.

Root cause

The attribute pattern in configValidation.ts uses Joi.string(), which only accepts string values. This was introduced in the original headTags PR and was not updated when boolean support was added to the types and renderer.

Solution

Change the pattern from Joi.string() to Joi.alternatives().try(Joi.string(), Joi.boolean()), matching the existing pattern used for storage.namespace in the same file.

Testing

Updated the existing validation test to reject non-string/non-boolean values (e.g., numbers) and added a regression test confirming boolean attributes like async: true are now accepted. All 223 config validation tests pass.

…#12120) The example artifacts were regenerated for the v3.10.1 maintenance release, which reverted the engine field from '>=24.14' back to '>=20.0' and left the sandbox node version at '18'. Update the examples to reflect current maintainer intent: - Bump engines.node from '>=20.0' to '>=24.14' (reapplies PR facebook#11914 change overwritten by PR facebook#11985) - Bump sandbox.config.json node from '18' to '24' (syncs with generateExamples.js updated in PR facebook#12080)

…acebook#12233) (AI-assisted)

netlify · Jul 7, 2026

✅ [V2]

Name	Link
🔨 Latest commit	`7fd4eb1`
🔍 Latest deploy log	https://app.netlify.com/projects/docusaurus-2/deploys/6a4fb7d2bceaa300083784bb
😎 Deploy Preview	https://deploy-preview-12238--docusaurus-2.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

slorber

don't modify examples, that's unrelated to the PR topic: one thing at a time

This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [@docusaurus/core](https://github.com/facebook/docusaurus) ([source](https://github.com/facebook/docusaurus/tree/HEAD/packages/docusaurus)) | [`3.10.1` → `3.10.2`](https://renovatebot.com/diffs/npm/@docusaurus%2fcore/3.10.1/3.10.2) | ![age](https://developer.mend.io/api/mc/badges/age/npm/@docusaurus%2fcore/3.10.2?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@docusaurus%2fcore/3.10.1/3.10.2?slim=true) | | [@docusaurus/faster](https://github.com/facebook/docusaurus) ([source](https://github.com/facebook/docusaurus/tree/HEAD/packages/docusaurus-faster)) | [`3.10.1` → `3.10.2`](https://renovatebot.com/diffs/npm/@docusaurus%2ffaster/3.10.1/3.10.2) | ![age](https://developer.mend.io/api/mc/badges/age/npm/@docusaurus%2ffaster/3.10.2?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@docusaurus%2ffaster/3.10.1/3.10.2?slim=true) | | [@docusaurus/module-type-aliases](https://github.com/facebook/docusaurus) ([source](https://github.com/facebook/docusaurus/tree/HEAD/packages/docusaurus-module-type-aliases)) | [`3.10.1` → `3.10.2`](https://renovatebot.com/diffs/npm/@docusaurus%2fmodule-type-aliases/3.10.1/3.10.2) | ![age](https://developer.mend.io/api/mc/badges/age/npm/@docusaurus%2fmodule-type-aliases/3.10.2?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@docusaurus%2fmodule-type-aliases/3.10.1/3.10.2?slim=true) | | [@docusaurus/plugin-content-docs](https://github.com/facebook/docusaurus) ([source](https://github.com/facebook/docusaurus/tree/HEAD/packages/docusaurus-plugin-content-docs)) | [`3.10.1` → `3.10.2`](https://renovatebot.com/diffs/npm/@docusaurus%2fplugin-content-docs/3.10.1/3.10.2) | ![age](https://developer.mend.io/api/mc/badges/age/npm/@docusaurus%2fplugin-content-docs/3.10.2?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@docusaurus%2fplugin-content-docs/3.10.1/3.10.2?slim=true) | | [@docusaurus/preset-classic](https://github.com/facebook/docusaurus) ([source](https://github.com/facebook/docusaurus/tree/HEAD/packages/docusaurus-preset-classic)) | [`3.10.1` → `3.10.2`](https://renovatebot.com/diffs/npm/@docusaurus%2fpreset-classic/3.10.1/3.10.2) | ![age](https://developer.mend.io/api/mc/badges/age/npm/@docusaurus%2fpreset-classic/3.10.2?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@docusaurus%2fpreset-classic/3.10.1/3.10.2?slim=true) | --- ### Release Notes <details> <summary>facebook/docusaurus (@docusaurus/core)</summary> ### [`v3.10.2`](https://github.com/facebook/docusaurus/blob/HEAD/CHANGELOG.md#3102-2026-07-10) [Compare Source](facebook/docusaurus@v3.10.1...v3.10.2) Backport and cherry-pick commits from main for v3.10.2 patch release: - [fix(bundler): do not import `@swc/html`, fix StackBlitz playground #12055](facebook/docusaurus#12055) - [fix(core): use locale url in site config #12054](facebook/docusaurus#12054) - [fix(theme-classic): remove redundant sidebar label titles #11966](facebook/docusaurus#11966) - [fix(mdx-loader): avoid transforming dotted directory links into asset… #11944](facebook/docusaurus#11944) - [fix(dev-server): for HTTPS, support non-RSA TLS certs #12065](facebook/docusaurus#12065) - [fix(utils): fix `extractLeadingEmoji()` edge cases #12100](facebook/docusaurus#12100) - [fix(gtag.js, faster): Fix StackBlitz, vendor `@types/gtag.js`, upgrade `@swc/html` #12080](facebook/docusaurus#12080) - [fix(create-docusaurus): init template README should use npm commands by default #12138](facebook/docusaurus#12138) - [fix(cli): `docusaurus serve` should pass `--host` to `server.listen()` #12127](facebook/docusaurus#12127) - [fix(core): bump detect-port to v2.1, fix pnpm `trustPolicy` downgrade issue #12012](facebook/docusaurus#12012) - [fix(i18n): complete Spanish translations for theme-common and theme-l… #12180](facebook/docusaurus#12180) - [chore(deps): migrate to `@11ty/gray-matter` #12181](facebook/docusaurus#12181) - [fix(core): fix BaseUrlIssueBanner little security issue #12260](facebook/docusaurus#12260) - [fix(core): accept boolean attributes in headTags config validation #12238](facebook/docusaurus#12238) - [fix(sitemap): don't drop lastmod for an epoch (0) timestamp #12212](facebook/docusaurus#12212) - [fix(utils): preserve author names containing commas in git log parsing #12069](facebook/docusaurus#12069) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).  --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Reviewed-on: https://gitea.com/gitea/docs/pulls/466 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Renovate Bot <renovate-bot@gitea.com>

DhineshPonnarasan added 2 commits June 6, 2026 20:31

fix(core): accept boolean attributes in headTags config validation (f…

d9619db

…acebook#12233) (AI-assisted)

DhineshPonnarasan requested review from Josh-Cena and slorber as code owners July 7, 2026 23:47

meta-cla Bot added the CLA Signed Signed Facebook CLA label Jul 7, 2026

DhineshPonnarasan changed the title ~~fix(core): accept boolean attributes in headTags config validation (AI-assisted)~~ fix(core): accept boolean attributes in headTags config validation Jul 8, 2026

slorber requested changes Jul 9, 2026

View reviewed changes

slorber added 6 commits July 9, 2026 17:01

Update examples/classic-typescript/package.json

1c536ed

Update examples/classic-typescript/sandbox.config.json

a4be020

Update examples/classic/sandbox.config.json

cbd0109

Update examples/classic-typescript/sandbox.config.json

a7e3ba2

Update examples/classic/package.json

bdddfac

Update examples/classic/sandbox.config.json

7fd4eb1

slorber merged commit f764082 into facebook:main Jul 9, 2026
36 of 37 checks passed

slorber added pr: bug fix This PR fixes a bug in a past release. to backport This PR is planned to be backported to a stable version of Docusaurus labels Jul 9, 2026

slorber mentioned this pull request Jul 10, 2026

chore: cherry-pick commits for v3.10.2 patch release #12265

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(core): accept boolean attributes in headTags config validation - #12238

fix(core): accept boolean attributes in headTags config validation #12238
slorber merged 8 commits into
facebook:mainfacebook/docusaurus:mainfrom
DhineshPonnarasan:fix/headtags-boolean-attributesDhineshPonnarasan/docusaurus:fix/headtags-boolean-attributesCopy head branch name to clipboard

DhineshPonnarasan commented Jul 7, 2026

Uh oh!

netlify Bot commented Jul 7, 2026 •

edited

Loading

Uh oh!

slorber left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Search code, repositories, users, issues, pull requests...

Uh oh!

Uh oh!

Conversation

DhineshPonnarasan commented Jul 7, 2026

Summary

Root cause

Solution

Testing

Uh oh!

netlify Bot commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ [V2]

Uh oh!

slorber left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify Bot commented Jul 7, 2026 •

edited

Loading