perf(urlencoded): move empty-body guard to avoid extra function closure - #647
#647Merged
jonchurch merged 1 commit intoJan 16, 2026
expressjs:masterexpressjs/body-parser:masterfrom
Phillip9587:urlencoded-remove-extra-closurePhillip9587/body-parser:urlencoded-remove-extra-closureCopy head branch name to clipboard
Merged
perf(urlencoded): move empty-body guard to avoid extra function closure#647jonchurch merged 1 commit intoexpressjs:masterexpressjs/body-parser:masterfrom Phillip9587:urlencoded-remove-extra-closurePhillip9587/body-parser:urlencoded-remove-extra-closureCopy head branch name to clipboard
jonchurch merged 1 commit into
expressjs:masterexpressjs/body-parser:masterfrom
Phillip9587:urlencoded-remove-extra-closurePhillip9587/body-parser:urlencoded-remove-extra-closureCopy head branch name to clipboard
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the URL-encoded body parsing by eliminating an extra function closure and moving the empty-body check directly into the parser function. The change improves performance by removing an unnecessary wrapper function while maintaining identical behavior.
- Moves empty-body guard from wrapper function to main parser function
- Eliminates extra function closure creation
- Changes
vartoconstfor the parser assignment
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Phillip9587
force-pushed
the
urlencoded-remove-extra-closure
branch
from
January 16, 2026 15:39
aa99cd5 to
3694fbc
Compare
jonchurch
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inlines the empty-body check into the parser returned by
createQueryParser, removing the extra wrapper function. The behavior is unchanged but we get a minor perf/alloc win by not creating a extra closure.