Add option to filter diagnostics by id - #1007
#1007Merged
JoeRobich merged 3 commits intoFeb 26, 2021
dotnet:masterdotnet/format:masterfrom
JoeRobich:add-diagnostics-filterJoeRobich/format:add-diagnostics-filterCopy head branch name to clipboard
Merged
Add option to filter diagnostics by id#1007JoeRobich merged 3 commits intodotnet:masterdotnet/format:masterfrom JoeRobich:add-diagnostics-filterJoeRobich/format:add-diagnostics-filterCopy head branch name to clipboard
JoeRobich merged 3 commits into
dotnet:masterdotnet/format:masterfrom
JoeRobich:add-diagnostics-filterJoeRobich/format:add-diagnostics-filterCopy head branch name to clipboard
Conversation
jmarolf
reviewed
Feb 26, 2021
| }, | ||
| new Option(new[] { "--diagnostics" }, Resources.A_space_separated_list_of_diagnostic_ids_to_use_as_a_filter_when_fixing_code_style_or_3rd_party_issues) | ||
| { | ||
| Argument = new Argument<string[]>(() => Array.Empty<string>()) |
Contributor
There was a problem hiding this comment.
I would like it if we could provide a helpful message if this option is provide and we are not in a --fix-stlye or --fix-analyzers mode
jmarolf
approved these changes
Feb 26, 2021
JoeRobich
force-pushed
the
add-diagnostics-filter
branch
from
February 26, 2021 16:43
4b40a17 to
ed79a06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1006