Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

BREAKING CHANGE: drop keepFileLink - #9417

#9417
Merged
yufeih merged 1 commit into
maindotnet/docfx:mainfrom
nokeepfilelinkdotnet/docfx:nokeepfilelinkCopy head branch name to clipboard
Nov 11, 2023
Merged

BREAKING CHANGE: drop keepFileLink#9417
yufeih merged 1 commit into
maindotnet/docfx:mainfrom
nokeepfilelinkdotnet/docfx:nokeepfilelinkCopy head branch name to clipboard

Conversation

@yufeih

@yufeih yufeih commented Nov 11, 2023

Copy link
Copy Markdown
Contributor

Fixes #9181

@yufeih yufeih added the breaking-change Makes the pull request appear in "Breaking Changes" section of the next release note label Nov 11, 2023
@yufeih yufeih changed the title Nokeepfilelink BREAKING CHANGE: drop keepFileLink Nov 11, 2023
@codecov

codecov Bot commented Nov 11, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/Docfx.App/Config/BuildJsonConfig.cs 100.00% <ø> (ø)
src/Docfx.App/Helpers/DocumentBuilderWrapper.cs 74.25% <ø> (+0.87%) ⬆️
src/Docfx.Build/DocumentBuildParameters.cs 100.00% <ø> (ø)
src/Docfx.Build/DocumentBuilder.cs 83.63% <100.00%> (+3.97%) ⬆️
src/docfx/Models/BuildCommand.cs 12.00% <ø> (-1.73%) ⬇️
src/docfx/Models/BuildCommandOptions.cs 86.36% <ø> (-0.60%) ⬇️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!

@yufeih
yufeih marked this pull request as ready for review November 11, 2023 10:42
@yufeih
yufeih merged commit 80d495b into main Nov 11, 2023
@yufeih
yufeih deleted the nokeepfilelink branch November 11, 2023 13:26
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Co-authored-by: Yufei Huang <yufeih@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change Makes the pull request appear in "Breaking Changes" section of the next release note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Remove keepFileLink option from config

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.