Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat: add --verbose command line args for verbose logging, drops --repositoryRoot - #9412

#9412
Merged
yufeih merged 1 commit into
maindotnet/docfx:mainfrom
loggingdotnet/docfx:loggingCopy head branch name to clipboard
Nov 10, 2023
Merged

feat: add --verbose command line args for verbose logging, drops --repositoryRoot#9412
yufeih merged 1 commit into
maindotnet/docfx:mainfrom
loggingdotnet/docfx:loggingCopy head branch name to clipboard

Conversation

@yufeih

@yufeih yufeih commented Nov 10, 2023

Copy link
Copy Markdown
Contributor

Makes it easier to turn on verbose logging using the --verbose command line arg.
Drops --repositoryRoot command line arg. When --log is specified to log to a file, always use the file path relative to docfx.json.

@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label Nov 10, 2023
@codecov

codecov Bot commented Nov 10, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/docfx/Models/LogOptions.cs 100.00% <100.00%> (+25.00%) ⬆️
src/docfx/Models/CommandHelper.cs 35.00% <0.00%> (-5.00%) ⬇️
src/Docfx.Common/Loggers/ReportLogListener.cs 0.00% <0.00%> (-74.00%) ⬇️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!

@yufeih
yufeih merged commit 97e7705 into main Nov 10, 2023
@yufeih
yufeih deleted the logging branch November 10, 2023 06:10
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
…positoryRoot (dotnet#9412)

Co-authored-by: Yufei Huang <yufeih@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature Makes the pull request to appear in "New Features" section of the next release note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.