Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix(lambda): fix typo in addPermission() warning message#37365

Merged
mergify[bot] merged 2 commits into
aws:mainaws/aws-cdk:mainfrom
syukawa-gh:fix/lambda-warning-message-typosyukawa-gh/aws-cdk:fix/lambda-warning-message-typoCopy head branch name to clipboard
Mar 26, 2026
Merged

fix(lambda): fix typo in addPermission() warning message#37365
mergify[bot] merged 2 commits into
aws:mainaws/aws-cdk:mainfrom
syukawa-gh:fix/lambda-warning-message-typosyukawa-gh/aws-cdk:fix/lambda-warning-message-typoCopy head branch name to clipboard

Conversation

@syukawa-gh

Copy link
Copy Markdown
Contributor

Reason for this change

The warning message displayed by addPermission() when called on a Lambda Function with mismatched environments contains a typo: "this is is intentional" (duplicated "is").

Description of changes

Fix this is is intentionalthis is intentional in:

  • packages/aws-cdk-lib/aws-lambda/lib/function-base.ts (source)
  • packages/aws-cdk-lib/aws-lambda/test/function.test.ts (test assertion)

Description of how you validated changes

Updated the corresponding test assertion to match the corrected message.

Checklist

Fix "this is is intentional" → "this is intentional" in the
warning message shown when addPermission() has no effect on a
Lambda Function with mismatched environments.
@github-actions github-actions Bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Mar 26, 2026
@aws-cdk-automation
aws-cdk-automation requested a review from a team March 26, 2026 08:31

@aws-cdk-automation aws-cdk-automation left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@rix0rrr rix0rrr added the pr-linter/exempt-test The PR linter will not require test changes label Mar 26, 2026
@rix0rrr rix0rrr added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Mar 26, 2026
@aws-cdk-automation
aws-cdk-automation dismissed their stale review March 26, 2026 14:08

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify

mergify Bot commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify

mergify Bot commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • Entered queue2026-03-26 14:52 UTC · Rule: default-squash
  • Checks passed · in-place
  • Merged2026-03-26 15:28 UTC · at 75955c8190a71038179f151b53b82d064895bb80

This pull request spent 36 minutes 30 seconds in the queue, including 36 minutes 7 seconds running CI.

Required conditions to merge

@mergify

mergify Bot commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
mergify Bot merged commit fa21e62 into aws:main Mar 26, 2026
18 of 19 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.