[ty] Avoid duplicate configuration error output - #26375
#26375Merged
MichaReiser merged 1 commit intoJun 25, 2026
mainastral-sh/ruff:mainfrom
micha/avoid-duplicate-config-errorsastral-sh/ruff:micha/avoid-duplicate-config-errorsCopy head branch name to clipboard
Merged
[ty] Avoid duplicate configuration error output#26375MichaReiser merged 1 commit intomainastral-sh/ruff:mainfrom micha/avoid-duplicate-config-errorsastral-sh/ruff:micha/avoid-duplicate-config-errorsCopy head branch name to clipboard
MichaReiser merged 1 commit into
mainastral-sh/ruff:mainfrom
micha/avoid-duplicate-config-errorsastral-sh/ruff:micha/avoid-duplicate-config-errorsCopy head branch name to clipboard
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 94.47%. The percentage of expected errors that received a diagnostic held steady at 89.19%. The number of fully passing files held steady at 95/134. |
Memory usage reportMemory usage unchanged ✅ |
|
MichaReiser
force-pushed
the
micha/avoid-duplicate-config-errors
branch
from
June 25, 2026 16:46
531ef4f to
39489db
Compare
MichaReiser
marked this pull request as ready for review
June 25, 2026 16:49
charliermarsh
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We iterate over the cause chain in ty's CLI. This prints the
sourceof every error. However, we also have some error variants that print their own source.This PR removes the inner
sourcefrom the message. Because it will be added when printing the error chain.Closes astral-sh/ty#3854
Test Plan
Updated tests