[ty] Use reachable first declaration in declaration-based diagnostics - #24564
#24564Merged
charliermarsh merged 1 commit intoApr 12, 2026
mainastral-sh/ruff:mainfrom
charlie/first-reachable-declarationsastral-sh/ruff:charlie/first-reachable-declarationsCopy head branch name to clipboard
Merged
[ty] Use reachable first declaration in declaration-based diagnostics#24564charliermarsh merged 1 commit intomainastral-sh/ruff:mainfrom charlie/first-reachable-declarationsastral-sh/ruff:charlie/first-reachable-declarationsCopy head branch name to clipboard
charliermarsh merged 1 commit into
mainastral-sh/ruff:mainfrom
charlie/first-reachable-declarationsastral-sh/ruff:charlie/first-reachable-declarationsCopy head branch name to clipboard
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 87.92%. The percentage of expected errors that received a diagnostic held steady at 83.11%. The number of fully passing files held steady at 78/133. |
Memory usage reportMemory usage unchanged ✅ |
|
charliermarsh
force-pushed
the
charlie/first-reachable-declarations
branch
from
April 11, 2026 19:38
ce0c87e to
3e6e8e5
Compare
charliermarsh
marked this pull request as ready for review
April 11, 2026 19:56
charliermarsh
requested review from
AlexWaygood,
carljm,
dcreager,
ibraheemdev and
sharkdp
as code owners
April 11, 2026 19:56
carljm
approved these changes
Apr 12, 2026
charliermarsh
force-pushed
the
charlie/first-reachable-declarations
branch
from
April 12, 2026 12:38
3e6e8e5 to
9ae0cab
Compare
charliermarsh
changed the base branch from
charlie/namedtuple-overrides-i
to
main
April 12, 2026 12:39
charliermarsh
force-pushed
the
charlie/first-reachable-declarations
branch
from
April 12, 2026 12:43
9ae0cab to
f765880
Compare
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We now use the first reachable declaration, rather than the first declaration, in certain diagnostics, e.g.: