Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[refurb] Expand fix safety for keyword arguments and Decimals (FURB164) - #21259

#21259
Merged
ntBre merged 1 commit into
astral-sh:mainastral-sh/ruff:mainfrom
chirizxc:furb164chirizxc/ruff:furb164Copy head branch name to clipboard
Nov 3, 2025
Merged

[refurb] Expand fix safety for keyword arguments and Decimals (FURB164)#21259
ntBre merged 1 commit into
astral-sh:mainastral-sh/ruff:mainfrom
chirizxc:furb164chirizxc/ruff:furb164Copy head branch name to clipboard

Conversation

@chirizxc

@chirizxc chirizxc commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

Summary

Fixes #21257

Test Plan

cargo nextest run furb164

@github-actions

github-actions Bot commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@ntBre ntBre added fixes Related to suggested fixes for violations preview Related to preview mode features labels Nov 3, 2025

@ntBre ntBre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It would be kind of nice if we could use our limited type inference infrastructure to check Decimal types for annotated variables and not just the direct constructor calls, but this seems like a good step in the right direction.

@ntBre ntBre changed the title [refurb] Fix FURB164 fixes [refurb] Expand fix safety for keyword arguments and Decimals (FURB164) Nov 3, 2025
@ntBre
ntBre merged commit 79a0271 into astral-sh:main Nov 3, 2025
39 checks passed
@chirizxc
chirizxc deleted the furb164 branch November 4, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fixes Related to suggested fixes for violations preview Related to preview mode features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FURB164 fixes should be safe in a few cases

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.