refactor(compiler): support matching template elements to foreign components#68674
Closed
leonsenft wants to merge 3 commits into
Closed
refactor(compiler): support matching template elements to foreign components#68674leonsenft wants to merge 3 commits into
leonsenft wants to merge 3 commits into
Conversation
195733b to
94cf03f
Compare
…s in templates We extract the identifier name from the `foreignImports` expression in `ComponentDecoratorHandler` and use a `SelectorlessMatcher` to match element tags against these names. If an element matches both a regular Angular directive and a foreign component, a conflict error is thrown. In addition, we implement strict template semantic validation for these matched foreign components within `TemplateSemanticsChecker`. Elements matched as foreign components only support static attributes and property bindings. Any event bindings, template references, or non-property input bindings (e.g. class, style, or attribute bindings) trigger a semantic error diagnostic. Finally, we skip standard DOM schema checks for foreign components to prevent spurious validation errors since foreign components are not defined in standard HTML schemas.
94cf03f to
b22195c
Compare
JeanMeche
reviewed
May 19, 2026
atscott
reviewed
May 19, 2026
Correctly matches and resolves foreign components when imported under an alias name inside the component file.
atscott
approved these changes
May 19, 2026
…mponents in templates
Contributor
Author
|
g3 failure is unrelated |
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken |
Contributor
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
leonsenft
added a commit
that referenced
this pull request
May 19, 2026
Correctly matches and resolves foreign components when imported under an alias name inside the component file. PR Close #68674
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We extract the identifier name from the
foreignImportsexpression inComponentDecoratorHandlerand use aSelectorlessMatcherto match element tags against these names. If an element matches both a regular Angular directive and a foreign component, a conflict error is thrown.In addition, we implement strict template semantic validation for these matched foreign components within
TemplateSemanticsChecker. Elements matched as foreign components only support static attributes and property bindings. Any event bindings, template references, or non-property input bindings (e.g. class, style, or attribute bindings) trigger a semantic error diagnostic.Finally, we skip standard DOM schema checks for foreign components to prevent spurious validation errors since foreign components are not defined in standard HTML schemas.