Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@crisbeto
Copy link
Member

This is a second attempt at #63857 with some fixes to avoid the breakages.

Updates the template syntax to support inline regular expressions. Also includes some logic to reuse regular expressions between call sites, unless they're marked as global.

@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Sep 17, 2025
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: docs Related to the documentation area: compiler Issues related to `ngc`, Angular's template compiler area: core Issues related to the framework runtime labels Sep 17, 2025
@ngbot ngbot bot added this to the Backlog milestone Sep 17, 2025
@crisbeto crisbeto added the action: global presubmit The PR is in need of a google3 global presubmit label Sep 17, 2025
Updates the expression lexer to produce tokens for regular expression literals.
Updates the template syntax to support inline regular expressions.
Adds the `RegularExpressionLiteral` node to the output AST.
…mpiler

Handles regular expression literals across the template type checker and the various translators.
Adds support for regular expression literals in the template pipeline and adds some logic to optimize non-global ones.
Updates the docs to mention that regular expressions are supported.
@crisbeto crisbeto force-pushed the template-regex-again branch from c5384bd to b634d15 Compare September 18, 2025 08:47
@crisbeto crisbeto removed the action: global presubmit The PR is in need of a google3 global presubmit label Sep 18, 2025
@crisbeto crisbeto requested a review from devversion September 18, 2025 13:09
@crisbeto crisbeto marked this pull request as ready for review September 18, 2025 13:09
@crisbeto
Copy link
Member Author

Passing TGP

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 18, 2025
thePunderWoman pushed a commit that referenced this pull request Sep 18, 2025
Updates the template syntax to support inline regular expressions.

PR Close #63887
thePunderWoman pushed a commit that referenced this pull request Sep 18, 2025
Adds the `RegularExpressionLiteral` node to the output AST.

PR Close #63887
thePunderWoman pushed a commit that referenced this pull request Sep 18, 2025
…mpiler (#63887)

Handles regular expression literals across the template type checker and the various translators.

PR Close #63887
thePunderWoman pushed a commit that referenced this pull request Sep 18, 2025
…ne (#63887)

Adds support for regular expression literals in the template pipeline and adds some logic to optimize non-global ones.

PR Close #63887
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

thePunderWoman pushed a commit that referenced this pull request Sep 18, 2025
Updates the docs to mention that regular expressions are supported.

PR Close #63887
wildcardalice pushed a commit to wildcardalice/angular that referenced this pull request Sep 18, 2025
Updates the expression lexer to produce tokens for regular expression literals.

PR Close angular#63887
wildcardalice pushed a commit to wildcardalice/angular that referenced this pull request Sep 18, 2025
Updates the template syntax to support inline regular expressions.

PR Close angular#63887
wildcardalice pushed a commit to wildcardalice/angular that referenced this pull request Sep 18, 2025
…lar#63887)

Adds the `RegularExpressionLiteral` node to the output AST.

PR Close angular#63887
wildcardalice pushed a commit to wildcardalice/angular that referenced this pull request Sep 18, 2025
…mpiler (angular#63887)

Handles regular expression literals across the template type checker and the various translators.

PR Close angular#63887
wildcardalice pushed a commit to wildcardalice/angular that referenced this pull request Sep 18, 2025
…ne (angular#63887)

Adds support for regular expression literals in the template pipeline and adds some logic to optimize non-global ones.

PR Close angular#63887
wildcardalice pushed a commit to wildcardalice/angular that referenced this pull request Sep 18, 2025
…#63887)

Updates the docs to mention that regular expressions are supported.

PR Close angular#63887
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler area: core Issues related to the framework runtime area: docs Related to the documentation detected: feature PR contains a feature commit target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.