feat(core): support regular expressions in templates #63857

crisbeto · Sep 17, 2025

Updates the template syntax to support inline regular expressions. Also includes some logic to reuse regular expressions between call sites, unless they're marked as global.

Updates the expression lexer to produce tokens for regular expression literals.

Updates the template syntax to support inline regular expressions.

Adds the `RegularExpressionLiteral` node to the output AST.

…mpiler Handles regular expression literals across the template type checker and the various translators.

Adds support for regular expression literals in the template pipeline and adds some logic to optimize non-global ones.

Updates the docs to mention that regular expressions are supported.

devversion

🎉

devversion · Sep 17, 2025

packages/compiler/src/expression_parser/lexer.ts

+      !lastToken.isString() &&
+      !lastToken.isKeyword() &&
+      !lastToken.isCharacter(chars.$RPAREN) &&
+      !lastToken.isCharacter(chars.$RBRACKET)


In what places is a regex starting? would it be less cases to catch where it can actually follow?

We need this logic, because the lexer works on a character-by-character basis. When we see a slash, we don't know if it'll be a regex or something like a / b.

Right, I guess I was trying to ask if it would be simpler to inverse the checks here. E.g. check for left parenthesis— but I think it would likely be more verbose than this, so LGTM

devversion · Sep 17, 2025

packages/compiler/src/output/output_ast.ts

+  }
+
+  override isConstant() {
+    return true;


does this have an affect on the template pipeline? do you recall where this is used?

If I remember correctly, we use it together with the constant pool to determine if a value can be extracted into a variable and reused. I'd consider regexes to be constant since they're immutable.

Ah I just wondered if the optimization logic with the g flag could be handled via isConstant here.

I just tried out removing the explicit optimization and relying on isConstant and the ConstantPool doing the right thing and it didn't work so things might've stopped working properly there at some point...

crisbeto · Sep 17, 2025

Caretaker note: we may have to patch cl/808162868 into the sync CL.

Updates the template syntax to support inline regular expressions. PR Close #63857

Adds the `RegularExpressionLiteral` node to the output AST. PR Close #63857

…mpiler (#63857) Handles regular expression literals across the template type checker and the various translators. PR Close #63857

…ne (#63857) Adds support for regular expression literals in the template pipeline and adds some logic to optimize non-global ones. PR Close #63857

thePunderWoman · Sep 17, 2025

This PR was merged into the repository. The changes were merged into the following branches:

main: 32c98e0

Updates the docs to mention that regular expressions are supported. PR Close #63857

…ngular#63857)" This reverts commit 32c98e0.

…o pipeline (angular#63857)" This reverts commit dd77233.

…n AOT compiler (angular#63857)" This reverts commit f2ef838.

…ns (angular#63857)" This reverts commit a1288f8.

…#63857)" This reverts commit 328a2bf.

…ular#63857)" This reverts commit 8a69c06.

…63857)" (#63883) This reverts commit 32c98e0. PR Close #63883

…o pipeline (#63857)" (#63883) This reverts commit dd77233. PR Close #63883

…n AOT compiler (#63857)" (#63883) This reverts commit f2ef838. PR Close #63883

…ns (#63857)" (#63883) This reverts commit a1288f8. PR Close #63883

#63883) This reverts commit 328a2bf. PR Close #63883

)" (#63883) This reverts commit 8a69c06. PR Close #63883

Updates the expression lexer to produce tokens for regular expression literals. PR Close angular#63857

Updates the template syntax to support inline regular expressions. PR Close angular#63857

…lar#63857) Adds the `RegularExpressionLiteral` node to the output AST. PR Close angular#63857

…mpiler (angular#63857) Handles regular expression literals across the template type checker and the various translators. PR Close angular#63857

…ne (angular#63857) Adds support for regular expression literals in the template pipeline and adds some logic to optimize non-global ones. PR Close angular#63857

…#63857) Updates the docs to mention that regular expressions are supported. PR Close angular#63857

…ngular#63857)" (angular#63883) This reverts commit 32c98e0. PR Close angular#63883

…o pipeline (angular#63857)" (angular#63883) This reverts commit dd77233. PR Close angular#63883

…n AOT compiler (angular#63857)" (angular#63883) This reverts commit f2ef838. PR Close angular#63883

…ns (angular#63857)" (angular#63883) This reverts commit a1288f8. PR Close angular#63883

…#63857)" (angular#63883) This reverts commit 328a2bf. PR Close angular#63883

…ular#63857)" (angular#63883) This reverts commit 8a69c06. PR Close angular#63883

angular-automatic-lock-bot · Oct 18, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

crisbeto added 6 commits September 17, 2025 07:39

refactor(compiler): tokenize regular expression literals

e04f67d

Updates the expression lexer to produce tokens for regular expression literals.

feat(core): support regular expressions in templates

958ef64

Updates the template syntax to support inline regular expressions.

refactor(compiler): add output AST node for regular expressions

b17f7df

Adds the `RegularExpressionLiteral` node to the output AST.

refactor(compiler-cli): support regular expression literals in AOT co…

62b81a2

…mpiler Handles regular expression literals across the template type checker and the various translators.

refactor(compiler): integrate regular expression literals into pipeline

784795e

Adds support for regular expression literals in the template pipeline and adds some logic to optimize non-global ones.

docs: add regular expressions to table of supported literals

cce3ff4

Updates the docs to mention that regular expressions are supported.

crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Sep 17, 2025

angular-robot bot added detected: feature PR contains a feature commit area: docs Related to the documentation area: compiler Issues related to `ngc`, Angular's template compiler area: core Issues related to the framework runtime labels Sep 17, 2025

ngbot bot added this to the Backlog milestone Sep 17, 2025

crisbeto requested a review from devversion September 17, 2025 08:52

crisbeto marked this pull request as ready for review September 17, 2025 08:52

pullapprove bot removed the request for review from devversion September 17, 2025 08:52

crisbeto requested a review from devversion September 17, 2025 09:13

devversion approved these changes Sep 17, 2025

View reviewed changes

thePunderWoman closed this in 8a69c06 Sep 17, 2025

thePunderWoman pushed a commit that referenced this pull request Sep 17, 2025

feat(core): support regular expressions in templates (#63857)

328a2bf

Updates the template syntax to support inline regular expressions. PR Close #63857

thePunderWoman pushed a commit that referenced this pull request Sep 17, 2025

refactor(compiler): add output AST node for regular expressions (#63857)

a1288f8

Adds the `RegularExpressionLiteral` node to the output AST. PR Close #63857

thePunderWoman pushed a commit that referenced this pull request Sep 17, 2025

refactor(compiler-cli): support regular expression literals in AOT co…

f2ef838

…mpiler (#63857) Handles regular expression literals across the template type checker and the various translators. PR Close #63857

thePunderWoman pushed a commit that referenced this pull request Sep 17, 2025

docs: add regular expressions to table of supported literals (#63857)

32c98e0

Updates the docs to mention that regular expressions are supported. PR Close #63857

AndrewKushnir added a commit to AndrewKushnir/angular that referenced this pull request Sep 17, 2025

Revert "docs: add regular expressions to table of supported literals (a…

a993f25

…ngular#63857)" This reverts commit 32c98e0.

AndrewKushnir added a commit to AndrewKushnir/angular that referenced this pull request Sep 17, 2025

Revert "refactor(compiler): integrate regular expression literals int…

1a8f9b8

…o pipeline (angular#63857)" This reverts commit dd77233.

AndrewKushnir added a commit to AndrewKushnir/angular that referenced this pull request Sep 17, 2025

Revert "refactor(compiler-cli): support regular expression literals i…

ba2bef6

…n AOT compiler (angular#63857)" This reverts commit f2ef838.

AndrewKushnir added a commit to AndrewKushnir/angular that referenced this pull request Sep 17, 2025

Revert "refactor(compiler): add output AST node for regular expressio…

07d07da

…ns (angular#63857)" This reverts commit a1288f8.

AndrewKushnir added a commit to AndrewKushnir/angular that referenced this pull request Sep 17, 2025

Revert "feat(core): support regular expressions in templates (angular…

e144222

…#63857)" This reverts commit 328a2bf.

AndrewKushnir added a commit to AndrewKushnir/angular that referenced this pull request Sep 17, 2025

Revert "refactor(compiler): tokenize regular expression literals (ang…

3e2e1ad

…ular#63857)" This reverts commit 8a69c06.

AndrewKushnir mentioned this pull request Sep 17, 2025

Revert "feat(core): support regular expressions in templates" #63883

Closed

thePunderWoman pushed a commit that referenced this pull request Sep 17, 2025

Revert "docs: add regular expressions to table of supported literals (#…

f0883e5

…63857)" (#63883) This reverts commit 32c98e0. PR Close #63883

thePunderWoman pushed a commit that referenced this pull request Sep 17, 2025

Revert "refactor(compiler): integrate regular expression literals int…

0a81784

…o pipeline (#63857)" (#63883) This reverts commit dd77233. PR Close #63883

thePunderWoman pushed a commit that referenced this pull request Sep 17, 2025

Revert "refactor(compiler-cli): support regular expression literals i…

f53c654

…n AOT compiler (#63857)" (#63883) This reverts commit f2ef838. PR Close #63883

thePunderWoman pushed a commit that referenced this pull request Sep 17, 2025

Revert "refactor(compiler): add output AST node for regular expressio…

c7e0c8b

…ns (#63857)" (#63883) This reverts commit a1288f8. PR Close #63883

thePunderWoman pushed a commit that referenced this pull request Sep 17, 2025

Revert "feat(core): support regular expressions in templates (#63857)" (

ae55578

#63883) This reverts commit 328a2bf. PR Close #63883

thePunderWoman pushed a commit that referenced this pull request Sep 17, 2025

Revert "refactor(compiler): tokenize regular expression literals (#63857

a53ef1d

)" (#63883) This reverts commit 8a69c06. PR Close #63883

crisbeto mentioned this pull request Sep 17, 2025

feat(core): support regular expressions in templates #63887

Closed

wildcardalice pushed a commit to wildcardalice/angular that referenced this pull request Sep 18, 2025

refactor(compiler): tokenize regular expression literals (angular#63857)

f17721e

Updates the expression lexer to produce tokens for regular expression literals. PR Close angular#63857

wildcardalice pushed a commit to wildcardalice/angular that referenced this pull request Sep 18, 2025

feat(core): support regular expressions in templates (angular#63857)

1363bd7

Updates the template syntax to support inline regular expressions. PR Close angular#63857

wildcardalice pushed a commit to wildcardalice/angular that referenced this pull request Sep 18, 2025

refactor(compiler): add output AST node for regular expressions (angu…

b5ffb2f

…lar#63857) Adds the `RegularExpressionLiteral` node to the output AST. PR Close angular#63857

wildcardalice pushed a commit to wildcardalice/angular that referenced this pull request Sep 18, 2025

docs: add regular expressions to table of supported literals (angular…

0c92f76

…#63857) Updates the docs to mention that regular expressions are supported. PR Close angular#63857

wildcardalice pushed a commit to wildcardalice/angular that referenced this pull request Sep 18, 2025

Revert "docs: add regular expressions to table of supported literals (a…

69f6a55

…ngular#63857)" (angular#63883) This reverts commit 32c98e0. PR Close angular#63883

wildcardalice pushed a commit to wildcardalice/angular that referenced this pull request Sep 18, 2025

Revert "refactor(compiler): integrate regular expression literals int…

dea809e

…o pipeline (angular#63857)" (angular#63883) This reverts commit dd77233. PR Close angular#63883

wildcardalice pushed a commit to wildcardalice/angular that referenced this pull request Sep 18, 2025

Revert "refactor(compiler-cli): support regular expression literals i…

06e2d80

…n AOT compiler (angular#63857)" (angular#63883) This reverts commit f2ef838. PR Close angular#63883

wildcardalice pushed a commit to wildcardalice/angular that referenced this pull request Sep 18, 2025

Revert "refactor(compiler): add output AST node for regular expressio…

7df65c9

…ns (angular#63857)" (angular#63883) This reverts commit a1288f8. PR Close angular#63883

wildcardalice pushed a commit to wildcardalice/angular that referenced this pull request Sep 18, 2025

Revert "feat(core): support regular expressions in templates (angular…

78a3354

…#63857)" (angular#63883) This reverts commit 328a2bf. PR Close angular#63883

wildcardalice pushed a commit to wildcardalice/angular that referenced this pull request Sep 18, 2025

Revert "refactor(compiler): tokenize regular expression literals (ang…

02fa140

…ular#63857)" (angular#63883) This reverts commit 8a69c06. PR Close angular#63883

angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(core): support regular expressions in templates #63857

feat(core): support regular expressions in templates #63857

Uh oh!

crisbeto commented Sep 17, 2025

Uh oh!

devversion left a comment

Uh oh!

devversion Sep 17, 2025 •

edited

Loading

Uh oh!

crisbeto Sep 17, 2025

Uh oh!

devversion Sep 17, 2025

Uh oh!

devversion Sep 17, 2025

Uh oh!

crisbeto Sep 17, 2025

Uh oh!

devversion Sep 17, 2025

Uh oh!

crisbeto Sep 17, 2025

Uh oh!

crisbeto commented Sep 17, 2025

Uh oh!

thePunderWoman commented Sep 17, 2025

Uh oh!

angular-automatic-lock-bot bot commented Oct 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Search code, repositories, users, issues, pull requests...

feat(core): support regular expressions in templates #63857

feat(core): support regular expressions in templates #63857

Uh oh!

Conversation

crisbeto commented Sep 17, 2025

Uh oh!

devversion left a comment

Choose a reason for hiding this comment

Uh oh!

devversion Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

crisbeto Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

devversion Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

devversion Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

crisbeto Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

devversion Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

crisbeto Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

crisbeto commented Sep 17, 2025

Uh oh!

thePunderWoman commented Sep 17, 2025

Uh oh!

angular-automatic-lock-bot bot commented Oct 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

devversion Sep 17, 2025 •

edited

Loading