[Patch only] Cherry-pick control flow diagnostic into patch branch#53387
Closed
crisbeto wants to merge 5 commits intoangular:17.0.xangular/angular:17.0.xfrom
crisbeto:17.0.x-contrl-flow-diagnosticcrisbeto/angular:17.0.x-contrl-flow-diagnosticCopy head branch name to clipboard
Closed
[Patch only] Cherry-pick control flow diagnostic into patch branch#53387crisbeto wants to merge 5 commits intoangular:17.0.xangular/angular:17.0.xfrom crisbeto:17.0.x-contrl-flow-diagnosticcrisbeto/angular:17.0.x-contrl-flow-diagnosticCopy head branch name to clipboard
crisbeto wants to merge 5 commits intoangular:17.0.xangular/angular:17.0.xfrom
crisbeto:17.0.x-contrl-flow-diagnosticcrisbeto/angular:17.0.x-contrl-flow-diagnosticCopy head branch name to clipboard
Conversation
…T nodes When doing directive matching in the compiler, we need to be able to create a selector from an AST node. We already have the utility, but these changes simplify the public API and expose it so it can be used in `compiler-cli`.
…spaces during template type checking These changes expose the `ngContentSelectors` and `preserveWhitespaces` metadata to the TCB so they can be used in the next commit to implement a new diagnostic.
…tainer The control flow projection diagnostic will mention `ng-container` as a workaround for projection multiple nodes. These changes add a couple of tests to ensure that the approach works.
…ent projection This is a follow-up to the fix from angular#52414. It adds a diagnostic that will tell users when a control flow is preventing its direct descendants from being projected into a specific component slot.
…t projection diagnostic These changes add an option to the `extendedDiagnostics` field that allows the check from angular#53190 to be disabled. This is a follow-up based on a recent discussion.
alxhub
approved these changes
Dec 6, 2023
pkozlowski-opensource
approved these changes
Dec 6, 2023
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
Reviewed-for: fw-core
jessicajaniuk
approved these changes
Dec 6, 2023
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
Contributor
|
This PR was merged into the repository by commit 66ecf4c. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick the changes from #53190 and #53311 into the patch branch.