fix(compiler-cli): add compiler option to disable control flow content projection diagnostic#53311
fix(compiler-cli): add compiler option to disable control flow content projection diagnostic#53311crisbeto wants to merge 1 commit intoangular:mainangular/angular:mainfrom crisbeto:disable-control-flow-diagcrisbeto/angular:disable-control-flow-diagCopy head branch name to clipboard
Conversation
There was a problem hiding this comment.
Note: it feels a bit weird to be special-casing this diagnostic as an extended diagnostic that's built into the compiler, but at the moment it seem possible to implement this as an extended diagnostic.
I have a branch where the check is implemented as an actual diagnostic and it passes our own tests, however when I tried installing it in two separate apps (Material dev app and an ng new app), it didn't work. It seems like calling TemplateTypeChecker.getSymbolOfNode from an extended diagnostic doesn't work.
Since the option do disable it is in the extendedDiagnostics field, we can easily swap out the implementation later without changing the functionality.
…t projection diagnostic These changes add an option to the `extendedDiagnostics` field that allows the check from angular#53190 to be disabled. This is a follow-up based on a recent discussion.
3f0a768 to
86b5618
Compare
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
|
This PR was merged into the repository by commit e620b3a. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…t projection diagnostic (angular#53311) These changes add an option to the `extendedDiagnostics` field that allows the check from angular#53190 to be disabled. This is a follow-up based on a recent discussion. PR Close angular#53311
…t projection diagnostic (angular#53311) These changes add an option to the `extendedDiagnostics` field that allows the check from angular#53190 to be disabled. This is a follow-up based on a recent discussion. PR Close angular#53311
…t projection diagnostic (angular#53311) These changes add an option to the `extendedDiagnostics` field that allows the check from angular#53190 to be disabled. This is a follow-up based on a recent discussion. PR Close angular#53311
These changes add an option to the
extendedDiagnosticsfield that allows the check from #53190 to be disabled. This is a follow-up based on a recent discussion.