Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Comments

Close side panel

fix(migrations): fixes control flow migration bugs with ng-template handling#53368

Closed
jessicajaniuk wants to merge 2 commits intoangular:mainangular/angular:mainfrom
jessicajaniuk:migration-fixesjessicajaniuk/angular:migration-fixesCopy head branch name to clipboard
Closed

fix(migrations): fixes control flow migration bugs with ng-template handling#53368
jessicajaniuk wants to merge 2 commits intoangular:mainangular/angular:mainfrom
jessicajaniuk:migration-fixesjessicajaniuk/angular:migration-fixesCopy head branch name to clipboard

Conversation

@jessicajaniuk
Copy link
Contributor

@jessicajaniuk jessicajaniuk commented Dec 5, 2023

This fixes two reported issues with ng-template handling in the control flow migration.

  1. ng-templates that have more templates nested inside not migrating properly
  2. references to templates that are not present in the given component, requiring conversion to a template outlet

fixes: #53361
fixes: #53362

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No

@thePunderWoman
fix(migrations): handle nested ng-template replacement safely in CF m…
d0e2d9d 
…igration

When there are ng-templates nested inside other ng-templates, the replacement and removal of the templates gets disrupted. Re-processing the templates in the file along the way resolves this issue.

fixes: angular#53362
@thePunderWoman
fix(migrations): handle templates outside of component in cf migration
2639410 
If a template is passed in as an input, the ng-template will not exist in the same component template. This will leave a template placeholder behind. This fix ensures that template placeholder gets turned into a template outlet.

fixes: angular#53361
@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: migrations Issues related to `ng update`/`ng generate` migrations labels Dec 5, 2023
@ngbot ngbot bot modified the milestone: Backlog Dec 5, 2023
This was referenced Dec 5, 2023
Closed
Closed
@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 5, 2023
@dylhunn
Copy link
Contributor

dylhunn commented Dec 6, 2023

This PR was merged into the repository by commit 01b18a4.

dylhunn pushed a commit that referenced this pull request Dec 6, 2023
@thePunderWoman @dylhunn
fix(migrations): handle nested ng-template replacement safely in CF m…
5104a89 
…igration (#53368)

When there are ng-templates nested inside other ng-templates, the replacement and removal of the templates gets disrupted. Re-processing the templates in the file along the way resolves this issue.

fixes: #53362

PR Close #53368
dylhunn pushed a commit that referenced this pull request Dec 6, 2023
@thePunderWoman @dylhunn
fix(migrations): handle templates outside of component in cf migration (
2a4e3f5 
#53368)

If a template is passed in as an input, the ng-template will not exist in the same component template. This will leave a template placeholder behind. This fix ensures that template placeholder gets turned into a template outlet.

fixes: #53361

PR Close #53368
@dylhunn dylhunn closed this in 5a0ed28 Dec 6, 2023
dylhunn pushed a commit that referenced this pull request Dec 6, 2023
@thePunderWoman @dylhunn
fix(migrations): handle templates outside of component in cf migration (
01b18a4 
#53368)

If a template is passed in as an input, the ng-template will not exist in the same component template. This will leave a template placeholder behind. This fix ensures that template placeholder gets turned into a template outlet.

fixes: #53361

PR Close #53368
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jan 6, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 6, 2024
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@thePunderWoman @ChellappanRajan
fix(migrations): handle nested ng-template replacement safely in CF m…
2deb14e 
…igration (angular#53368)

When there are ng-templates nested inside other ng-templates, the replacement and removal of the templates gets disrupted. Re-processing the templates in the file along the way resolves this issue.

fixes: angular#53362

PR Close angular#53368
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@thePunderWoman @ChellappanRajan
fix(migrations): handle templates outside of component in cf migration (
2b8cdb3 
angular#53368)

If a template is passed in as an input, the ng-template will not exist in the same component template. This will leave a template placeholder behind. This fix ensures that template placeholder gets turned into a template outlet.

fixes: angular#53361

PR Close angular#53368
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
@thePunderWoman @rlmestre
fix(migrations): handle nested ng-template replacement safely in CF m…
f9411eb 
…igration (angular#53368)

When there are ng-templates nested inside other ng-templates, the replacement and removal of the templates gets disrupted. Re-processing the templates in the file along the way resolves this issue.

fixes: angular#53362

PR Close angular#53368
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
@thePunderWoman @rlmestre
fix(migrations): handle templates outside of component in cf migration (
cb6ab10 
angular#53368)

If a template is passed in as an input, the ng-template will not exist in the same component template. This will leave a template placeholder behind. This fix ensures that template placeholder gets turned into a template outlet.

fixes: angular#53361

PR Close angular#53368
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
@thePunderWoman @amilamen
fix(migrations): handle nested ng-template replacement safely in CF m…
86ae7f6 
…igration (angular#53368)

When there are ng-templates nested inside other ng-templates, the replacement and removal of the templates gets disrupted. Re-processing the templates in the file along the way resolves this issue.

fixes: angular#53362

PR Close angular#53368
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
@thePunderWoman @amilamen
fix(migrations): handle templates outside of component in cf migration (
e9eb9d8 
angular#53368)

If a template is passed in as an input, the ng-template will not exist in the same component template. This will leave a template placeholder behind. This fix ensures that template placeholder gets turned into a template outlet.

fixes: angular#53361

PR Close angular#53368
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

4 participants

@jessicajaniuk @dylhunn @crisbeto @thePunderWoman
Morty Proxy This is a proxified and sanitized view of the page, visit original site.