Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Control flow schematic: ngIf with else condition template not migrated correctly#53361

Copy link
Copy link
@mattlewis92

Description

@mattlewis92
Issue body actions

Which @angular/* package(s) are the source of the bug?

core

Is this a regression?

No

Description

Sorry, it looks like I missed a few straggling issues! 馃槄

Input (defaultTemplate is assumed to be a template passed in via a component input):

<button *ngIf="active; else defaultTemplate">Hello!</button> 

Output:

@if (active) {
  <button>Hello!</button>
} @else {
  #defaultTemplate|
}

Expected output:

@if (active) {
  <button>Hello!</button>
} @else {
  <ng-template [ngTemplateOutlet]="defaultTemplate"></ng-template>
}

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

No response

Please provide the environment you discovered this bug in (run ng version)

Angular CLI: 17.0.5
Node: 20.9.0
Package Manager: pnpm 8.11.0
OS: darwin arm64

Angular: 17.0.5+sha-2d2eaec
... core

Package                             Version
-------------------------------------------------------------
@angular-devkit/architect           0.1700.1
@angular-devkit/build-angular       17.0.5
@angular-devkit/core                17.0.5
@angular-devkit/schematics          17.0.5
@angular/animations                 17.0.5
@angular/cdk                        17.0.1
@angular/cli                        17.0.5
@angular/common                     17.0.5
@angular/compiler                   17.0.5
@angular/compiler-cli               17.0.5
@angular/elements                   17.0.5
@angular/forms                      17.0.5
@angular/google-maps                15.2.9
@angular/language-service           17.0.5
@angular/localize                   17.0.5
@angular/platform-browser           17.0.5
@angular/platform-browser-dynamic   17.0.5
@angular/router                     17.0.5
@angular/service-worker             17.0.5
@schematics/angular                 17.0.5
ng-packagr                          17.0.2
rxjs                                7.8.0
typescript                          5.2.2
webpack                             5.88.2
zone.js                             0.14.2

Anything else?

This is using the latest core-builds version via "@angular/core": "angular/core-builds#17.0.5+2d2eaec",

Reactions are currently unavailable

Metadata

Metadata

Assignees

Labels

area: migrationsIssues related to `ng update`/`ng generate` migrationsIssues related to `ng update`/`ng generate` migrationscore: control flowIssues related to the built-in control flow (@if, @for, @switch)Issues related to the built-in control flow (@if, @for, @switch)

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.