Allow a stream target for a text extension - #1810
#1810Merged
SimonCropp merged 1 commit intoJul 21, 2026
mainVerifyTests/Verify:mainfrom
text-extension-stream-targetVerifyTests/Verify:text-extension-stream-targetCopy head branch name to clipboard
Merged
Allow a stream target for a text extension#1810SimonCropp merged 1 commit intomainVerifyTests/Verify:mainfrom text-extension-stream-targetVerifyTests/Verify:text-extension-stream-targetCopy head branch name to clipboard
SimonCropp merged 1 commit into
mainVerifyTests/Verify:mainfrom
text-extension-stream-targetVerifyTests/Verify:text-extension-stream-targetCopy head branch name to clipboard
Conversation
Since conversion splitters were allowed for text extensions (#1778), a converter registered against a text extension could still not re-emit its source: the Target stream constructor threw for text extensions. eg Verify.ImageMagick returns the svg alongside the rendered png. The stream is now read as text, applying the same newline fixing already used when a stream is read into a text target.
This was referenced Jul 21, 2026
This was referenced Jul 27, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since conversion splitters were allowed for text extensions (#1778), a converter registered against a text extension could still not re-emit its source: the Target stream constructor threw for text extensions. eg Verify.ImageMagick returns the svg alongside the rendered png.
The stream is now read as text, applying the same newline fixing already used when a stream is read into a text target.