Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Use upstream zizmor release notes for releases#51

Open
abhinavgautam01 wants to merge 2 commits into
zizmorcore:mainzizmorcore/zizmor-pre-commit:mainfrom
abhinavgautam01:issue-42-release-notesabhinavgautam01/zizmor-pre-commit:issue-42-release-notesCopy head branch name to clipboard
Open

Use upstream zizmor release notes for releases#51
abhinavgautam01 wants to merge 2 commits into
zizmorcore:mainzizmorcore/zizmor-pre-commit:mainfrom
abhinavgautam01:issue-42-release-notesabhinavgautam01/zizmor-pre-commit:issue-42-release-notesCopy head branch name to clipboard

Conversation

@abhinavgautam01

Copy link
Copy Markdown

Pre-submission checks

Please check these boxes:

  • Mandatory: This PR corresponds to an issue (if not, please create
    one first).

  • Having read the AI policy, I hereby disclose the use of an LLM or other
    AI coding assistant in the creation of this PR. PRs will not be rejected
    for using AI tools, but will be rejected for undisclosed use or
    use that violates the policy.

If a checkbox is not applicable, you can leave it unchecked.

Summary

Fixes #42

Updates the release workflow to populate zizmor-pre-commit GitHub releases with the matching upstream zizmor release notes instead of only linking to them.

If the upstream release body is empty, the workflow falls back to the existing release-specific link.

Test Plan

  • uvx pre-commit run --all-files
  • git diff --check
  • gh release view v1.24.0 --repo zizmorcore/zizmor --json body --jq '.body // ""'

@woodruffw woodruffw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abhinavgautam01. This looks reasonable to me, one question.

Comment thread .github/workflows/main.yml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please provide full release notes for each release

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.