fix: Move toggleDot files to fileModel and force re render on toggle by lazysegtree · Pull Request #1324 · yorukot/superfile

lazysegtree · Jan 26, 2026

and enforce a max render delay

Fixes - #981

Summary by CodeRabbit

Refactor
- Improved internal architecture of file panel management for better code organization and maintainability.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

… and enforce a max render delay

coderabbitai · Jan 26, 2026

📝 Walkthrough

Walkthrough

This PR refactors the file model initialization and dot-file toggle handling. It moves the toggleDotFile state from the main model to fileModel, introduces a constructor for fileModel with a public DisplayDotFiles field, adds ToggleDotFile() and UpdateFilePanelsIfNeeded() methods to encapsulate panel update logic, and simplifies the UpdateElementsIfNeeded() signature.

Changes

Cohort / File(s)	Summary
Constants and model state management `src/internal/common/ui_consts.go`, `src/internal/type.go`, `src/internal/ui/filemodel/type.go`	Removed `ReRenderChunkDivisor` from public UI constants; removed `toggleDotFile` and `updatedToggleDotFile` fields from main model struct; added `DisplayDotFiles` field to fileModel
FileModel initialization and update encapsulation `src/internal/default_config.go`, `src/internal/ui/filemodel/utils.go`, `src/internal/ui/filemodel/update.go`	Introduced `New()` constructor for fileModel initialization replacing manual struct construction; added `ToggleDotFile()` and `UpdateFilePanelsIfNeeded()` methods to encapsulate panel update logic
Main model refactoring `src/internal/handle_panel_movement.go`, `src/internal/model.go`	Replaced direct toggle state manipulation with calls to `fileModel.ToggleDotFile()`; removed `getFilePanelItems()` helper function; delegated to `UpdateFilePanelsIfNeeded()`
FilePanel update and render throttling `src/internal/ui/filepanel/consts.go`, `src/internal/ui/filepanel/get_elements.go`, `src/internal/ui/filepanel/render.go`	Moved re-render constants to filepanel module; simplified `UpdateElementsIfNeeded()` signature to accept `force` and `displayDotFile` flags; updated `shouldSkipPanelUpdate()` throttling mechanism; updated documentation comment in render logic

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

refactor: separate FilePanel into dedicated package #1195: Extracts and refactors the fileModel with new initialization and update APIs that align with this PR's changes to ToggleDotFile(), UpdateFilePanelsIfNeeded(), and the constructor pattern.
feat: Bug fix, navigation changes and refactoring #1219: Directly modifies the same file-model update flow, touching UpdateElementsIfNeeded(), ToggleDotFile(), and displayDotFile parameter handling.
chore: enable MND linter and fix all magic number issues #1180: Involves the ReRenderChunkDivisor constant movement and filepanel re-render throttling changes that overlap with this PR's updates to rendering logic.

Suggested labels

awaiting pr review

Suggested reviewers

yorukot

Poem

🐰 Hopping through the code with joy,
States refactored, cleaner toy,
DotFiles toggle in fileModel's care,
Updates flow with structured flair,
Constants moved to where they belong—
This refactor makes the code more strong! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main changes: moving toggleDot files to fileModel and forcing re-render on toggle, which are the primary objectives reflected throughout the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cloudflare-workers-and-pages · Jan 26, 2026

Deploying superfile with Cloudflare Pages

Latest commit:	`20c48c5`
Status:	✅ Deploy successful!
Preview URL:	https://a3ac2084.superfile.pages.dev
Branch Preview URL:	https://filepanel-state-fix.superfile.pages.dev

View logs

lazysegtree · Jan 26, 2026

 	HeightBreakC = 40
 	HeightBreakD = 45

-	ReRenderChunkDivisor = 100 // divisor for re-render throttling


moved to filepanel package

fix: Move toggleDot files to fileModel and force re render on toggle,…

5df71da

… and enforce a max render delay

lazysegtree added 2 commits January 26, 2026 20:41

fix: Use displayDotFile

acf8e28

fix: Remove unnecessary diff

20c48c5

lazysegtree commented Jan 26, 2026

View reviewed changes

lazysegtree requested a review from yorukot January 26, 2026 16:05

yorukot approved these changes Jan 26, 2026

View reviewed changes

lazysegtree merged commit fa3a42c into main Jan 26, 2026
14 checks passed

lazysegtree deleted the filepanel-state-fix branch January 26, 2026 16:37

lazysegtree mentioned this pull request Jan 26, 2026

Feature: Restore previous panel layout and directories (with current working dir override) #914

Open

BrewTestBot mentioned this pull request Jun 7, 2026

superfile 1.6.0 Homebrew/homebrew-core#286731

Merged

coderabbitai Bot mentioned this pull request Jul 4, 2026

feat(filepanel): add directories-only filter toggle #1510

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Move toggleDot files to fileModel and force re render on toggle#1324

fix: Move toggleDot files to fileModel and force re render on toggle#1324
lazysegtree merged 3 commits into
mainyorukot/superfile:mainfrom
filepanel-state-fixyorukot/superfile:filepanel-state-fixCopy head branch name to clipboard

lazysegtree commented Jan 26, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jan 26, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

cloudflare-workers-and-pages Bot commented Jan 26, 2026 •

edited

Loading

Uh oh!

lazysegtree Jan 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Search code, repositories, users, issues, pull requests...

Uh oh!

Conversation

lazysegtree commented Jan 26, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

cloudflare-workers-and-pages Bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying superfile with Cloudflare Pages

Uh oh!

lazysegtree Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lazysegtree commented Jan 26, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jan 26, 2026 •

edited

Loading

cloudflare-workers-and-pages Bot commented Jan 26, 2026 •

edited

Loading