fix: check and fix file panel scroll position on height changes by nikero41 · Pull Request #1095 · yorukot/superfile

nikero41 · Sep 27, 2025

I would like some comments on this fix. Not sure if it's complete.
For example if the fix placement looks fine or should I look elsewhere.

The idea is that whenever the heights are changed, we check if the cursor is always made visible.
After that the navigation functions can manage the filePanel.render

Something that is missing, from the current PR, is to reduce the filePanel.render, if the last item is already visible.

Fixes #820 (This also fixes the cursors when the window is resized)

Summary by CodeRabbit

Bug Fixes
- Keeps the selected item in file panels visible when the window or panel height changes.
- Ensures all file panels correctly adjust their rendering bounds during resize, preventing sudden jumps or hidden selections.
- Delivers smoother, more consistent navigation after resizing.

coderabbitai · Sep 27, 2025

Walkthrough

Adds a resize handler to keep the file panel cursor within the visible range on height changes, and wires it into the model’s height update routine so all file panels adjust when the main panel height changes.

Changes

Cohort / File(s)	Summary of Changes
File panel resize handling `src/internal/file_panel.go`, `src/internal/model.go`	Introduces `filePanel.handleResize(height int)` to clamp render window around the cursor, and invokes it from `setHeightValues` for each file panel after recalculating `mainPanelHeight`.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant UI as UI/Terminal
  participant Model as Model.setHeightValues
  participant Panels as FilePanel(s)

  User->>UI: Toggle footer / resize terminal
  UI->>Model: Update heights
  Model->>Model: Compute mainPanelHeight
  loop For each file panel
    Model->>Panels: handleResize(mainPanelHeight)
    activate Panels
    Panels->>Panels: Clamp render window to keep cursor visible
    deactivate Panels
  end
  Model-->>UI: Updated state
  UI-->>User: Re-render with cursor in view

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I nudge the footer, hop—surprise!
The panels stretch to match the skies.
My cursor, snug, won’t slip from view,
A tidy warren, rendered true.
With gentle bounds and measured size,
The burrow fits—no need for sighs. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title accurately and concisely describes the primary change of ensuring the file panel scroll position is checked and corrected when its height changes, directly reflecting the new handleResize logic and its invocation on height updates.
Linked Issues Check	✅ Passed	This PR adds a handleResize method that recalculates and clamps the file panel render offset to keep the cursor visible on height changes and calls it from setHeightValues for all panels, directly fulfilling issue #820’s requirement to maintain cursor visibility when toggling the footer or resizing the terminal.
Out of Scope Changes Check	✅ Passed	The only modifications introduced are the new handleResize function in filePanel and its invocation within height adjustment logic, with no additional unrelated code or features modified.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 52ba3cd and 021fbf9.

📒 Files selected for processing (2)

src/internal/file_panel.go (1 hunks)
src/internal/model.go (1 hunks)

🔇 Additional comments (2)

src/internal/model.go (1)

288-290: LGTM! Clean implementation following reviewer feedback.

The loop correctly calls handleResize on all file panels after computing the main panel height, ensuring cursor visibility is maintained across all panels when the height changes (footer toggle, window resize). This addresses the reviewer's earlier suggestion to define a function on the filePanel type.

src/internal/file_panel.go (1)

96-108: Approve cursor-clamping logic in handleResize
panelElementHeight is defined in the same package (src/internal/function.go) and the bounds logic correctly keeps the cursor in view.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

lazysegtree · Sep 27, 2025

+		if filePanel.render < filePanel.cursor-panelElementHeight(m.mainPanelHeight)+1 {
+			filePanel.render = filePanel.cursor - panelElementHeight(m.mainPanelHeight) + 1
+			m.fileModel.filePanels[index] = filePanel
+		}


This is good as of now, It feels like a duct tape solution, but I dont have better ideas. I would just suggest define a function for filePanel type - something like handleResize or handleHeightChange and just call that here.
would make it clearer

for index := range m.fileModel.filePanels { m.fileModel.filePanels[index].handleResize() }

lazysegtree · Sep 27, 2025

Thanks for this fix and the kitty protocol clearing fix.

lazysegtree · Sep 27, 2025

Nice to see new contributors.

…to expand

nikero41 · Oct 7, 2025

This is my first project that I meaningfully contribute. I hope I can help more.

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [yorukot/superfile](https://github.com/yorukot/superfile) | minor | `v1.3.3` -> `v1.4.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>yorukot/superfile (yorukot/superfile)</summary> ### [`v1.4.0`](https://github.com/yorukot/superfile/releases/tag/v1.4.0) [Compare Source](yorukot/superfile@v1.3.3...v1.4.0) Hey folks. Releasing v1.4.0 with many new features, improvements, and bug fixes. We have an async file preview now, a zoxide panel, and various new features improving UX. #### Install: [**Click me to know how to install**](https://github.com/yorukot/superfile?tab=readme-ov-file#installation) #### Highlights - We have the Zoxide Panel now. Ensure zoxide is installed on your system, set `zoxide_support` to `true` in the config, and press `z` to use zoxide. <img width="645" height="295" alt="Image" src="https://github.com/user-attachments/assets/238f6549-5318-49d1-a3a0-14cf8a686955" /> - File previewing is now async, meaning reduced lag while scrolling through images, or on slow systems. - Many bug fixes. See 'Detailed Change Summary' ##### Internal Updates - Most file operations are now truly async with the usage of the recommended `tea.Cmd` pattern. - Enabled many new linters to improve code quality. - Moved golangci-lint to v2. Now developers don't need to keep the old v1 in their systems. - Refactored file preview in its own package for better maintainability and readability. - Fixed flaky unit tests. #### Detailed Change Summary <details><summary>Details</summary> <p> ##### Update - feat: File operation via tea cmd [#963](yorukot/superfile#963) by @lazysegtree - feat: processbar improvements, package separation, better channel management [#973](yorukot/superfile#973) by @lazysegtree - feat: enable lll and recvcheck linter, fix tests, more refactors [#977](yorukot/superfile#977) by @lazysegtree - feat: Remove channel for notification models [#979](yorukot/superfile#979) by @lazysegtree - feat: enable cyclop, funlen, gocognit, gocyclo linters, and refactor large functions [#984](yorukot/superfile#984) by @lazysegtree - feat: Add a new hotkey to handle cd-on-quit whenever needed [#924](yorukot/superfile#924) by @ahmed-habbachi - feat: added option to permanently delete files [#987](yorukot/superfile#987) by @hupender - feat: Preview panel separation [#1021](yorukot/superfile#1021) by @lazysegtree - feat: Add search functionality to help menu [#1011](yorukot/superfile#1011) by @iZarrios - feat: Use zoxide lib [#1036](yorukot/superfile#1036) by @lazysegtree - feat: Add zoxide directory tracking on navigation [#1041](yorukot/superfile#1041) by @lazysegtree - feat: Zoxide integration [#1039](yorukot/superfile#1039) by @lazysegtree - feat: Select mode with better feedback [#1074](yorukot/superfile#1074) by @lazysegtree - feat: owner/group in the metadata [#1093](yorukot/superfile#1093) by @xelavopelk - feat: Async zoxide [#1104](yorukot/superfile#1104) by @lazysegtree ##### Bug Fix - fix: sorting in searchbar [#985](yorukot/superfile#985) by @hupender - fix: Async rendering, Include clipboard check in paste items, and update linter configs [#997](yorukot/superfile#997) by @lazysegtree - fix: Move utility functions to utils package [#1012](yorukot/superfile#1012) by @lazysegtree - fix: Refactoring and separation of preview panel and searchbar in help menu [#1013](yorukot/superfile#1013) by @lazysegtree - fix(filePanel): allow focusType to be set correctly [#1033](yorukot/superfile#1033) by @faisal-990 - fix(ci): Update gomod2nix.toml, allow pre release in version output, release 1.4.0-rc1, bug fixes, and improvements [#1054](yorukot/superfile#1054) by @lazysegtree - fix(nix): resolve build failures in the nix flake [#1068](yorukot/superfile#1068) by @Frost-Phoenix - fix: Retry the file deletion to prevent flakies (#938) [#1076](yorukot/superfile#1076) by @lazysegtree - fix(issue-1066): Fixed issue where enter was not searchable [#1078](yorukot/superfile#1078) by @Simpaqt - fix(#1073): Tech debt fix [#1077](yorukot/superfile#1077) by @Simpaqt - fix: fix deleted directory not able to remove from pins (#1067) [#1081](yorukot/superfile#1081) by @yorukot - fix: fix child process spawning attached [#1084](yorukot/superfile#1084) by @guemidiborhane - fix: always clear images when showing a FullScreenStyle [#1094](yorukot/superfile#1094) by @snikoletopoulos - fix: Allow j and k keys in zoxide [#1102](yorukot/superfile#1102) by @lazysegtree - fix: Zoxide improvements and 1.4.0-rc2 [#1105](yorukot/superfile#1105) by @lazysegtree - fix: rename cursor beginning on wrong character because of multiple dots in name (#813) [#1112](yorukot/superfile#1112) by @SyedAsadK - fix: check and fix file panel scroll position on height changes [#1095](yorukot/superfile#1095) by @snikoletopoulos ##### Optimization - perf(website): optimize font loading and asset organization [#1089](yorukot/superfile#1089) by @yorukot ##### Documentation - docs: fix incorrect zoxide plugin config name [#1049](yorukot/superfile#1049) by @shree-xvi - docs(hotkeys): Fix typo in vimHotkeys.toml comments [#1080](yorukot/superfile#1080) by @wleoncio - docs: add section for core maintainers in README.md [#1088](yorukot/superfile#1088) by @yorukot - chore: add winget install instruction to readme and website [#943](yorukot/superfile#943) by @claykom ##### Dependencies - chore(deps): update dependency go to v1.25.0, golangci-lint to v2, golangci-lint actions to v8 [#750](yorukot/superfile#750) by @renovate[bot] - chore(deps): update amannn/action-semantic-pull-request action to v6 [#1006](yorukot/superfile#1006) by @renovate[bot] - chore(deps): update actions/first-interaction action to v3 [#1005](yorukot/superfile#1005) by @renovate[bot] - chore(deps): update actions/checkout action to v5 [#1004](yorukot/superfile#1004) by @renovate[bot] - chore(deps): bump astro from 5.10.1 to 5.12.8 [#982](yorukot/superfile#982) by @dependabot[bot] - fix(deps): update module golang.org/x/mod to v0.27.0 [#989](yorukot/superfile#989) by @renovate[bot] - fix(deps): update dependency @expressive-code/plugin-collapsible-sections to v0.41.3 [#990](yorukot/superfile#990) by @renovate[bot] - fix(deps): update dependency sharp to v0.34.3 [#992](yorukot/superfile#992) by @renovate[bot] - fix(deps): update dependency @expressive-code/plugin-line-numbers to v0.41.3 [#991](yorukot/superfile#991) by @renovate[bot] - chore(deps): update dependency go to v1.25.0 [#994](yorukot/superfile#994) by @renovate[bot] - fix(deps): update astro monorepo [#995](yorukot/superfile#995) by @renovate[bot] - fix(deps): update dependency @astrojs/starlight to ^0.35.0 [#1000](yorukot/superfile#1000) by @renovate[bot] - fix(deps): update module github.com/urfave/cli/v3 to v3.4.1 [#1001](yorukot/superfile#1001) by @renovate[bot] - fix(deps): update module golang.org/x/text to v0.28.0 [#1003](yorukot/superfile#1003) by @renovate[bot] ##### Misc - chore: migrate from superfile.netlify.app to superfile.dev [#1087](yorukot/superfile#1087) by @yorukot - refactor(filepanel): replace filePanelFocusType with isFocused boolean [#1040](yorukot/superfile#1040) by @faisal-990 - refactor(ansi): Migrate from github.com/charmbracelet/x/exp/term/ansi to github.com/charmbracelet/x/ansi [#1044](yorukot/superfile#1044) by @faisal-990 - refactor: common operation on pinned directory file using PinnedManager [#1085](yorukot/superfile#1085) by @Manaswa-S - test: unit tests for pinned manager [#1090](yorukot/superfile#1090) by @Manaswa-S </p> </details> #### New Contributors * @hupender made their first contribution in yorukot/superfile#985 * @ahmed-habbachi made their first contribution in yorukot/superfile#924 * @iZarrios made their first contribution in yorukot/superfile#1011 * @faisal-990 made their first contribution in yorukot/superfile#1033 * @shree-xvi made their first contribution in yorukot/superfile#1049 * @Simpaqt made their first contribution in yorukot/superfile#1078 * @wleoncio made their first contribution in yorukot/superfile#1080 * @guemidiborhane made their first contribution in yorukot/superfile#1084 * @Manaswa-S made their first contribution in yorukot/superfile#1085 * @xelavopelk made their first contribution in yorukot/superfile#1093 * @snikoletopoulos made their first contribution in yorukot/superfile#1094 * @SyedAsadK made their first contribution in yorukot/superfile#1112 **Full Changelog**: <yorukot/superfile@v1.3.3...v1.4.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

fix: check and fix file panel scroll position on height changes

e1d5c60

lazysegtree reviewed Sep 27, 2025

View reviewed changes

fix: move resizing logic and check for available space for the panel …

755f559

…to expand

nikero41 marked this pull request as ready for review October 7, 2025 21:58

Merge branch 'main' into keep-cursor-in-view

021fbf9

lazysegtree approved these changes Oct 8, 2025

View reviewed changes

lazysegtree merged commit f85c195 into yorukot:main Oct 8, 2025
7 of 9 checks passed

nikero41 deleted the keep-cursor-in-view branch October 8, 2025 20:45

BrewTestBot mentioned this pull request Oct 10, 2025

superfile 1.4.0 Homebrew/homebrew-core#248116

Merged

coderabbitai Bot mentioned this pull request Dec 7, 2025

feat: allow hover to file #1177

Merged

This was referenced Dec 21, 2025

fix: update metadata and process bar sizes when toggling footer #1218

Merged

feat: Enable fast configurable navigation #1220

Merged

fix: More layout fixes, complete end to end layout unit tests #1227

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: check and fix file panel scroll position on height changes#1095

fix: check and fix file panel scroll position on height changes#1095
lazysegtree merged 3 commits into
yorukot:mainyorukot/superfile:mainfrom
nikero41:keep-cursor-in-viewnikero41/superfile:keep-cursor-in-viewCopy head branch name to clipboard

nikero41 commented Sep 27, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Sep 27, 2025 •

edited

Loading

Uh oh!

lazysegtree Sep 27, 2025 •

edited

Loading

Uh oh!

lazysegtree commented Sep 27, 2025

Uh oh!

lazysegtree commented Sep 27, 2025

Uh oh!

nikero41 commented Oct 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Search code, repositories, users, issues, pull requests...

Uh oh!

Conversation

nikero41 commented Sep 27, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Sep 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Poem

Pre-merge checks and finishing touches

Uh oh!

lazysegtree Sep 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lazysegtree commented Sep 27, 2025

Uh oh!

lazysegtree commented Sep 27, 2025

Uh oh!

nikero41 commented Oct 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nikero41 commented Sep 27, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 27, 2025 •

edited

Loading

lazysegtree Sep 27, 2025 •

edited

Loading