Add mapping-style get method to CF accessors#658
Open
Kkkakania wants to merge 1 commit into
xarray-contrib:mainxarray-contrib/cf-xarray:mainfrom
Kkkakania:agent/accessor-getKkkakania/cf-xarray:agent/accessor-getCopy head branch name to clipboard
Open
Add mapping-style get method to CF accessors#658Kkkakania wants to merge 1 commit intoxarray-contrib:mainxarray-contrib/cf-xarray:mainfrom Kkkakania:agent/accessor-getKkkakania/cf-xarray:agent/accessor-getCopy head branch name to clipboard
Kkkakania wants to merge 1 commit into
xarray-contrib:mainxarray-contrib/cf-xarray:mainfrom
Kkkakania:agent/accessor-getKkkakania/cf-xarray:agent/accessor-getCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CFAccessor.get()that delegates to each accessor's existing__getitem__implementationNoneor a caller-provided default only when CF lookup raisesKeyErrorFixes #127.
Verification
uvx ruff check cf_xarray/accessor.py cf_xarray/tests/test_accessor.pyuvx ruff format --check cf_xarray/accessor.py cf_xarray/tests/test_accessor.pyuv run --group test pytest cf_xarray/tests/test_accessor.py -q(216 passed, 1 skipped)AI assistance
I used Codex to inspect the shared accessor hierarchy and draft the implementation and tests. I reviewed the behavior against both Dataset and DataArray accessors and can maintain the submitted changes.