Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 2039e0d

Browse filesBrowse files
committed
rework TODOs
1 parent dac0bfe commit 2039e0d
Copy full SHA for 2039e0d

3 files changed

+3-1Lines changed: 3 additions & 1 deletion

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎test/_helper.js‎

Copy file name to clipboardExpand all lines: test/_helper.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ module.exports.init = function(fixture = 'default', config = {}, markup) {
6363
return new Promise((resolve, reject) => {
6464
ready(() => {
6565
const docsify = new Docsify()
66-
// TODO: use callback instead of polling, but usually it works after 10ms
66+
// NOTE: I was not able to get it working with a callback, but polling works usually at the first time
6767
const id = setInterval(() => {
6868
if (dom.window.document.body.innerHTML.indexOf(NOT_INIT_PATTERN) == -1) {
6969
clearInterval(id)
Collapse file

‎test/integration/render.js‎

Copy file name to clipboardExpand all lines: test/integration/render.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ describe('full docsify initialization', function() {
88
it('TODO: check generated markup', async function() {
99
const {docsify, dom} = await init('simple', {loadSidebar: true})
1010
console.log(dom.window.document.body.innerHTML)
11+
// TODO: add some expectations
1112
})
1213

1314
})
Collapse file

‎test/integration/router.js‎

Copy file name to clipboardExpand all lines: test/integration/router.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ describe('router', function() {
88
it('TODO: trigger to load another page', async function() {
99
const {docsify} = await init()
1010
window.location = '/?foo=bar'
11+
// TODO: add some expectations
1112
})
1213

1314
})

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.