Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

ci: update tests to test against WordPress 6.4 - #266

#266
Merged
jasonbahl merged 5 commits into
mainwp-graphql/wp-graphql-smart-cache:mainfrom
feat/#263-test-wp6.4wp-graphql/wp-graphql-smart-cache:feat/#263-test-wp6.4Copy head branch name to clipboard
Dec 11, 2023
Merged

ci: update tests to test against WordPress 6.4#266
jasonbahl merged 5 commits into
mainwp-graphql/wp-graphql-smart-cache:mainfrom
feat/#263-test-wp6.4wp-graphql/wp-graphql-smart-cache:feat/#263-test-wp6.4Copy head branch name to clipboard

Conversation

@jasonbahl

@jasonbahl jasonbahl commented Dec 11, 2023

Copy link
Copy Markdown
Collaborator
  • updates tests to test against WordPress 6.4
  • updates README, plugin file accordingly

closes #263

@jasonbahl jasonbahl self-assigned this Dec 11, 2023

@josephfusco josephfusco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See feedback

Comment thread src/Cache/Collection.php
// Save/add the node ids for this query. When one of these change in the future, we can purge the query
foreach ( $runtime_nodes as $node_id ) {
$this->store_content( $node_id, $request_key );
$this->store_content( (string) $node_id, $request_key );

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a changelog entry needed for this?

Comment thread readme.txt Outdated
Comment thread wp-graphql-smart-cache.php Outdated
jasonbahl and others added 2 commits December 11, 2023 14:01
Co-authored-by: Joe Fusco <josephfusco@users.noreply.github.com>
Co-authored-by: Joe Fusco <josephfusco@users.noreply.github.com>
@jasonbahl
jasonbahl merged commit cb6384b into main Dec 11, 2023
@jasonbahl jasonbahl mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test WPGraphQL Smart Cache on WP 6.4

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.