Phpstan level 5,6 - #241
#241Merged
markkelnar merged 4 commits intoAug 2, 2023
wp-graphql:mainwp-graphql/wp-graphql-smart-cache:mainfrom
markkelnar:phpstan-level-5markkelnar/wp-graphql-smart-cache:phpstan-level-5Copy head branch name to clipboard
Merged
Phpstan level 5,6#241markkelnar merged 4 commits intowp-graphql:mainwp-graphql/wp-graphql-smart-cache:mainfrom markkelnar:phpstan-level-5markkelnar/wp-graphql-smart-cache:phpstan-level-5Copy head branch name to clipboard
markkelnar merged 4 commits into
wp-graphql:mainwp-graphql/wp-graphql-smart-cache:mainfrom
markkelnar:phpstan-level-5markkelnar/wp-graphql-smart-cache:phpstan-level-5Copy head branch name to clipboard
Conversation
8 tasks
markkelnar
commented
Aug 2, 2023
| new Error( | ||
| self::deniedDocumentMessage(), | ||
| [ $node ] | ||
| $node |
Contributor
Author
There was a problem hiding this comment.
Looking deep in the graphql-php error constructor, this single $node gets converted to [$node]. That's why I feel this is the change needed.
jasonbahl
requested changes
Aug 2, 2023
jasonbahl
approved these changes
Aug 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase and fix phpstan levels 5 and 6.
Reference issue