Ensure code after wp-settings.php call is loaded#6042
Merged
Merged
Ensure code after wp-settings.php call is loaded#6042
wp-settings.php call is loaded#6042Conversation
Member
Author
|
@mrsdizzie pinging you directly because you helped review the other one & I made a mistake there |
mrsdizzie
approved these changes
Jan 31, 2025
mrsdizzie
left a comment
Member
There was a problem hiding this comment.
Ah I see 😅 I've tested this locally against config command as well and that test no longer fails
nlemoine
added a commit
to nlemoine/wpstarter
that referenced
this pull request
May 12, 2025
From 2.12, WP-CLI uses a more accurate regex to check that `wp-settings.php` has been required. See: - wp-cli/wp-cli#6039 - wp-cli/wp-cli#6042
3 tasks
nlemoine
added a commit
to nlemoine/wpstarter
that referenced
this pull request
May 16, 2025
From 2.12, WP-CLI uses a more accurate regex to check that `wp-settings.php` has been required. See: - wp-cli/wp-cli#6039 - wp-cli/wp-cli#6042
nlemoine
added a commit
to nlemoine/wpstarter
that referenced
this pull request
May 16, 2025
From 2.12, WP-CLI uses a more accurate regex to check that `wp-settings.php` has been required. See: - wp-cli/wp-cli#6039 - wp-cli/wp-cli#6042
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a logical mistake in #6039 that I didn't realize until tests in config-command started failing.
Basically, the
wp-settings.phpcall needs to be omitted, but the code after that still needs to be eval'd.