Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

don't forcefully exec() docker version#6040

Merged
swissspidy merged 1 commit into
wp-cli:mainwp-cli/wp-cli:mainfrom
drzraf:optional-docker-execdrzraf/wp-cli:optional-docker-execCopy head branch name to clipboard
Apr 29, 2025
Merged

don't forcefully exec() docker version#6040
swissspidy merged 1 commit into
wp-cli:mainwp-cli/wp-cli:mainfrom
drzraf:optional-docker-execdrzraf/wp-cli:optional-docker-execCopy head branch name to clipboard

Conversation

@drzraf

@drzraf drzraf commented Jan 30, 2025

Copy link
Copy Markdown

If we don't intend to connect through docker, don't even exec() it in the first place: Less syscalls and more apparmor-friendly behavior

@drzraf drzraf requested a review from a team as a code owner January 30, 2025 18:31
@drzraf drzraf force-pushed the optional-docker-exec branch from dec7b4d to 31055e9 Compare February 10, 2025 17:37
@swissspidy

Copy link
Copy Markdown
Member

Testing is a bit difficult at the moment because #5974 broke a test.

… the first place. Less syscalls and more apparmor-friendly behavior
@drzraf drzraf force-pushed the optional-docker-exec branch from 31055e9 to 0882b70 Compare March 4, 2025 22:46
@codecov-commenter

codecov-commenter commented Mar 4, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
php/WP_CLI/Runner.php 0.00% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

@drzraf

drzraf commented Apr 24, 2025

Copy link
Copy Markdown
Author

ping?

@schlessera schlessera mentioned this pull request Apr 29, 2025
47 tasks
@mrsdizzie mrsdizzie added this to the 2.12.0 milestone Apr 29, 2025
@swissspidy swissspidy merged commit d3b6cee into wp-cli:main Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.