Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

PHPUnit: convert deprecations to exceptions#5994

Merged
swissspidy merged 6 commits into
mainwp-cli/wp-cli:mainfrom
update-phpunit-configwp-cli/wp-cli:update-phpunit-configCopy head branch name to clipboard
Oct 1, 2024
Merged

PHPUnit: convert deprecations to exceptions#5994
swissspidy merged 6 commits into
mainwp-cli/wp-cli:mainfrom
update-phpunit-configwp-cli/wp-cli:update-phpunit-configCopy head branch name to clipboard

Conversation

@swissspidy

Copy link
Copy Markdown
Member

Since PHPUnit 9.5.10 and 8.5.21, PHP deprecations are no longer converted to exceptions by default (convertDeprecationsToExceptions="true" can be configured to enable this).

This commit reverts PHPUnit to the previous behaviour by adding convertDeprecationsToExceptions="true" to the PHPUnit configuration. It also adds the other related directives for consistency.

See similar change in core: WordPress/wordpress-develop@7c2b54e

@swissspidy swissspidy added the scope:testing Related to testing label Oct 1, 2024
@swissspidy swissspidy added this to the 2.12.0 milestone Oct 1, 2024
@swissspidy swissspidy requested a review from a team as a code owner October 1, 2024 10:38
@swissspidy swissspidy merged commit ce3ac48 into main Oct 1, 2024
@swissspidy swissspidy deleted the update-phpunit-config branch October 1, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.