Update log and warning logger functions comment according to the actual functionality#5979
Merged
schlessera merged 1 commit intoFeb 5, 2025
wp-cli:mainwp-cli/wp-cli:mainfrom
matiasbenedetto:add/quiet-to-commentmatiasbenedetto/wp-cli:add/quiet-to-commentCopy head branch name to clipboard
Merged
Update log and warning logger functions comment according to the actual functionality#5979schlessera merged 1 commit intowp-cli:mainwp-cli/wp-cli:mainfrom matiasbenedetto:add/quiet-to-commentmatiasbenedetto/wp-cli:add/quiet-to-commentCopy head branch name to clipboard
schlessera merged 1 commit into
wp-cli:mainwp-cli/wp-cli:mainfrom
matiasbenedetto:add/quiet-to-commentmatiasbenedetto/wp-cli:add/quiet-to-commentCopy head branch name to clipboard
Conversation
schlessera
approved these changes
Feb 5, 2025
Member
|
Thanks for the PR, @matiasbenedetto ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Update
logandwarninglogger functions comment according to the actual functionality.In this PR I'm updating those 2 function comments to state that as the other logging function being muted by the
--quietcommand. Example:wp-cli/php/class-wp-cli.php
Line 773 in 0a48e09
Why?
Both functions log nothing when running wp-cli with
--quietoption.Reference:
wp-cli/php/WP_CLI/Loggers/Quiet.php
Lines 37 to 44 in 0a48e09