Correct completion case when ends in =#5913
Merged
danielbachhuber merged 1 commit intoMar 7, 2024
wp-cli:mainwp-cli/wp-cli:mainfrom
Roy-Orbison:completion-fix-fixRoy-Orbison/wp-cli:completion-fix-fixCopy head branch name to clipboard
Merged
Correct completion case when ends in =#5913danielbachhuber merged 1 commit intowp-cli:mainwp-cli/wp-cli:mainfrom Roy-Orbison:completion-fix-fixRoy-Orbison/wp-cli:completion-fix-fixCopy head branch name to clipboard
danielbachhuber merged 1 commit into
wp-cli:mainwp-cli/wp-cli:mainfrom
Roy-Orbison:completion-fix-fixRoy-Orbison/wp-cli:completion-fix-fixCopy head branch name to clipboard
Conversation
1235af4 to
c9484be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further to #5873, I incorrectly handled options that end in
=and have already been completed. Any candidates offered immediately after such an option are treated by shells as possible values to concatenate, not possible names of the current option. Consequently, thiswill tab-complete to
I have added an extra condition to prevent that case.