Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove the pre-commit hook installation and its corresponding command#5868

Merged
danielbachhuber merged 1 commit into
wp-cli:mainwp-cli/wp-cli:mainfrom
johnbillion:remove-pre-commitjohnbillion/wp-cli:remove-pre-commitCopy head branch name to clipboard
Nov 10, 2023
Merged

Remove the pre-commit hook installation and its corresponding command#5868
danielbachhuber merged 1 commit into
wp-cli:mainwp-cli/wp-cli:mainfrom
johnbillion:remove-pre-commitjohnbillion/wp-cli:remove-pre-commitCopy head branch name to clipboard

Conversation

@johnbillion

@johnbillion johnbillion commented Nov 10, 2023

Copy link
Copy Markdown
Contributor

Fixes #5480

See #5859

This removes the script which sets up the pre-commit hook and its corresponding script.

If you have this pre-commit script installed, you can remove it by deleting the .git/hooks/pre-commit file.

Steps for testing

  1. Clone this repo
  2. Switch to this branch
  3. Run composer install
  4. Confirm no pre-commit hook has been installed into .git/hooks/pre-commit
  5. Commit some code that would normally fail coding standards checks
  6. Confirm there's no error message and the commit succeeds

If you have this pre-commit script installed, you can remove it by deleting the `.git/hooks/pre-commit` file.
@danielbachhuber danielbachhuber added this to the 2.10.0 milestone Nov 10, 2023
@danielbachhuber danielbachhuber added the scope:testing Related to testing label Nov 10, 2023
@danielbachhuber danielbachhuber merged commit 28803df into wp-cli:main Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.