Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Update tests to accommodate for SQLite#5849

Merged
danielbachhuber merged 5 commits into
mainwp-cli/wp-cli:mainfrom
fix/sqlite-testswp-cli/wp-cli:fix/sqlite-testsCopy head branch name to clipboard
Nov 1, 2023
Merged

Update tests to accommodate for SQLite#5849
danielbachhuber merged 5 commits into
mainwp-cli/wp-cli:mainfrom
fix/sqlite-testswp-cli/wp-cli:fix/sqlite-testsCopy head branch name to clipboard

Conversation

@swissspidy

@swissspidy swissspidy commented Oct 25, 2023

Copy link
Copy Markdown
Member

One functionality change:

In wp_not_installed() the list of found table prefixes is now explicitly sorted in ascending order. Without that, order would differ between MySQL and SQLite.

@swissspidy swissspidy added the scope:testing Related to testing label Oct 25, 2023
@swissspidy swissspidy added this to the 2.10.0 milestone Oct 25, 2023
@swissspidy swissspidy changed the title Fix SQLite tests Update tests to accommodate for SQLite Oct 25, 2023
@swissspidy swissspidy marked this pull request as ready for review October 26, 2023 07:50
@swissspidy swissspidy requested a review from a team as a code owner October 26, 2023 07:50
@danielbachhuber danielbachhuber merged commit 9239cff into main Nov 1, 2023
@danielbachhuber danielbachhuber deleted the fix/sqlite-tests branch November 1, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.