Add support for the proxyjump key#5805
Merged
swissspidy merged 3 commits intoAug 30, 2023
wp-cli:mainwp-cli/wp-cli:mainfrom
Mike-Hermans:alias-add-proxyjump-supportMike-Hermans/wp-cli:alias-add-proxyjump-supportCopy head branch name to clipboard
Merged
Add support for the proxyjump key#5805swissspidy merged 3 commits intowp-cli:mainwp-cli/wp-cli:mainfrom Mike-Hermans:alias-add-proxyjump-supportMike-Hermans/wp-cli:alias-add-proxyjump-supportCopy head branch name to clipboard
swissspidy merged 3 commits into
wp-cli:mainwp-cli/wp-cli:mainfrom
Mike-Hermans:alias-add-proxyjump-supportMike-Hermans/wp-cli:alias-add-proxyjump-supportCopy head branch name to clipboard
Conversation
NielsdeBlaauw
commented
Jun 8, 2023
Co-authored-by: Niels de Blaauw <niels.de.blaauw@gmail.com>
schlessera
approved these changes
Jun 8, 2023
Contributor
|
HI @schlessera, I've updated the tests so they work with the escaped shell args we use. |
swissspidy
approved these changes
Aug 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSH has the capability to route traffic through a proxy. This is done using the
-J xxxargument. The ProxyJump can be used for security purposes by limiting access to remote servers to specific IP addresses.Previously it had to use wp-cli with a proxy in between. The only somewhat practical way was adding it to your personal
~/.ssh/config:But this is technical and has to be done on every single machine in a team of multiple contributors.
This PR adds an option
proxyjumpto the alias specification so thewp-cli.ymlconfig file can specify a comon proxy for all traffic to go through.The change also includes a fix for the
keyattribute. It was part of the options for vagrant but did not seem possible for regular SSH commands, even though is can be usefull.