Remove old global terms feature test#5682
Closed
danielbachhuber wants to merge 1 commit into
masterwp-cli/wp-cli:masterfrom
remove/old-global-terms-testwp-cli/wp-cli:remove/old-global-terms-testCopy head branch name to clipboard
Closed
Remove old global terms feature test#5682danielbachhuber wants to merge 1 commit intomasterwp-cli/wp-cli:masterfrom remove/old-global-terms-testwp-cli/wp-cli:remove/old-global-terms-testCopy head branch name to clipboard
danielbachhuber wants to merge 1 commit into
masterwp-cli/wp-cli:masterfrom
remove/old-global-terms-testwp-cli/wp-cli:remove/old-global-terms-testCopy head branch name to clipboard
Conversation
Member
|
I chose to still keep the test around for now via #5684 but making it conditional, instead of just removing it. |
Member
Author
|
@schlessera Sounds fine! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Global terms were formally removed from WordPress core: https://core.trac.wordpress.org/ticket/21734#comment:27
The feature never worked well in the first place, and isn't something we need backwards compat for.