Address some PHP 8.1 deprecation notices#5658
Merged
danielbachhuber merged 2 commits intoJul 28, 2022
masterwp-cli/wp-cli:masterfrom
fix/5623-deprecation-noticeswp-cli/wp-cli:fix/5623-deprecation-noticesCopy head branch name to clipboard
Merged
Address some PHP 8.1 deprecation notices#5658danielbachhuber merged 2 commits intomasterwp-cli/wp-cli:masterfrom fix/5623-deprecation-noticeswp-cli/wp-cli:fix/5623-deprecation-noticesCopy head branch name to clipboard
danielbachhuber merged 2 commits into
masterwp-cli/wp-cli:masterfrom
fix/5623-deprecation-noticeswp-cli/wp-cli:fix/5623-deprecation-noticesCopy head branch name to clipboard
Conversation
According to the docblock, the method is supposed to default to the current working dir, but in reality it could return `null` if nothing was found. This breaks other methods like `::set_wp_root()` which expect a string. Prevents PHP deprecation notices because `null` was passed to `realpath()`.
Prevents PHP deprecation notices when inadvertently passing `null` to the function and thus `rtrim`.
danielbachhuber
approved these changes
Jul 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure
Runner::find_wp_root()always returns a directoryAccording to the docblock, the method is supposed to default to the current working dir, but in reality it could return
nullif nothing was found.This breaks other methods like
::set_wp_root()which expect a string.Prevents PHP deprecation notices because
nullwas passed torealpath().Handle null values in
trailingslashitutilPrevents PHP deprecation notices when inadvertently passing
nullto the function and thusrtrim.