Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Handle optional option values in SynopsisParser::render()#5618

Merged
schlessera merged 3 commits into
wp-cli:masterwp-cli/wp-cli:masterfrom
ssnepenthe:optional-option-valueCopy head branch name to clipboard
Jun 30, 2022
Merged

Handle optional option values in SynopsisParser::render()#5618
schlessera merged 3 commits into
wp-cli:masterwp-cli/wp-cli:masterfrom
ssnepenthe:optional-option-valueCopy head branch name to clipboard

Conversation

@ssnepenthe

Copy link
Copy Markdown
Contributor

Fixes #5617

@ssnepenthe ssnepenthe requested a review from a team as a code owner February 7, 2022 20:57
Comment thread tests/test-synopsis.php Outdated
@ssnepenthe

Copy link
Copy Markdown
Contributor Author

@wojsmol is there anything else that needs to be addressed in order for the pr to be merged?

@schlessera schlessera added this to the 2.7.0 milestone Jun 30, 2022
@schlessera schlessera merged commit 5508a6d into wp-cli:master Jun 30, 2022
@schlessera schlessera changed the title Handle optional option values in SynopsisParser::render() Handle optional option values in SynopsisParser::render() Jun 30, 2022
@drzraf

drzraf commented Feb 21, 2023

Copy link
Copy Markdown

I believe the combination with default doesn't work. (It'd gives true as a value instead of the one defined by default contrary to the string-based synopsis)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to register option with optional value using array synopsis syntax

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.