Detect and ignore BOMs#5597
Merged
schlessera merged 3 commits intoJan 6, 2022
masterwp-cli/wp-cli:masterfrom
fix/5578-detect-and-strip-bom-in-wp-config.phpwp-cli/wp-cli:fix/5578-detect-and-strip-bom-in-wp-config.phpCopy head branch name to clipboard
Merged
Detect and ignore BOMs#5597schlessera merged 3 commits intomasterwp-cli/wp-cli:masterfrom fix/5578-detect-and-strip-bom-in-wp-config.phpwp-cli/wp-cli:fix/5578-detect-and-strip-bom-in-wp-config.phpCopy head branch name to clipboard
schlessera merged 3 commits into
masterwp-cli/wp-cli:masterfrom
fix/5578-detect-and-strip-bom-in-wp-config.phpwp-cli/wp-cli:fix/5578-detect-and-strip-bom-in-wp-config.phpCopy head branch name to clipboard
Conversation
cbe60f3 to
7357ff9
Compare
swissspidy
approved these changes
Jan 5, 2022
7357ff9 to
44eb815
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds byte-order marks (BOM) detection to the logic that parses the
wp-config.phpfile for loading WP within the WP-CLI context.If a BOM is detected, WP-CLI issues a warning and then strips that BOM for further parsing.
Fixes #5577
Fixes #5578