Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Disable automatic retry by default on certificate validation error#5523

Merged
schlessera merged 9 commits into
masterwp-cli/wp-cli:masterfrom
fix/require-insecure-flag-for-http-retrywp-cli/wp-cli:fix/require-insecure-flag-for-http-retryCopy head branch name to clipboard
May 10, 2021
Merged

Disable automatic retry by default on certificate validation error#5523
schlessera merged 9 commits into
masterwp-cli/wp-cli:masterfrom
fix/require-insecure-flag-for-http-retrywp-cli/wp-cli:fix/require-insecure-flag-for-http-retryCopy head branch name to clipboard

Conversation

@schlessera

@schlessera schlessera commented May 6, 2021

Copy link
Copy Markdown
Member

This PR disables the automatic retrying of Utils/http_request() that was skipping certificate validation.

The new default is to produce a hard error on certificate errors.

This PR also adds a new --insecure flag to the cli update command that turns this retrying back on when explicitly requested, which allows manually going back to the previous behavior.

Subsequent PRs on the command repositories will add a similar --insecure flag to the appropriate commands on the following repositories:

@schlessera schlessera force-pushed the fix/require-insecure-flag-for-http-retry branch from 25b6969 to 69a352b Compare May 10, 2021 15:01
@schlessera schlessera merged commit 6f4e5dd into master May 10, 2021
@schlessera schlessera deleted the fix/require-insecure-flag-for-http-retry branch May 10, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.