Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[PHP 8] Add properties argument to __set_state magic method#5469

Merged
schlessera merged 1 commit into
wp-cli:masterwp-cli/wp-cli:masterfrom
TimothyBJacobs:patch-1TimothyBJacobs/wp-cli:patch-1Copy head branch name to clipboard
Nov 12, 2020
Merged

[PHP 8] Add properties argument to __set_state magic method#5469
schlessera merged 1 commit into
wp-cli:masterwp-cli/wp-cli:masterfrom
TimothyBJacobs:patch-1TimothyBJacobs/wp-cli:patch-1Copy head branch name to clipboard

Conversation

@TimothyBJacobs

Copy link
Copy Markdown
Contributor

On PHP 8 a fatal error is issued if a magic method doesn't match the expected signature.

PHP Fatal error:  Method Test_Magic_Methods::__set_state() must take exactly 1 argument

@TimothyBJacobs TimothyBJacobs requested a review from a team as a code owner November 11, 2020 18:44
@schlessera schlessera added the scope:testing Related to testing label Nov 12, 2020
@schlessera schlessera added this to the 2.5.0 milestone Nov 12, 2020
@schlessera schlessera merged commit 6af36bf into wp-cli:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.