Fix non static methods in Extractor_Test class call statically#5457
Merged
schlessera merged 1 commit intoOct 31, 2020
wp-cli:masterwp-cli/wp-cli:masterfrom
ediamin:fix_non_static_method_calls_in_extractor_test_classediamin/wp-cli:fix_non_static_method_calls_in_extractor_test_classCopy head branch name to clipboard
Merged
Fix non static methods in Extractor_Test class call statically#5457schlessera merged 1 commit intowp-cli:masterwp-cli/wp-cli:masterfrom ediamin:fix_non_static_method_calls_in_extractor_test_classediamin/wp-cli:fix_non_static_method_calls_in_extractor_test_classCopy head branch name to clipboard
schlessera merged 1 commit into
wp-cli:masterwp-cli/wp-cli:masterfrom
ediamin:fix_non_static_method_calls_in_extractor_test_classediamin/wp-cli:fix_non_static_method_calls_in_extractor_test_classCopy head branch name to clipboard
Conversation
schlessera
approved these changes
Oct 31, 2020
Member
|
Thanks for the PR, @ediamin ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The non static
create_test_directory_structureandrecursive_scandirmethods inExtractor_Testclass are called statically in same class in other methods. This PR just add static keyword to those methods and fix the problem.