Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix typos and docs standards and URL.#5337

Merged
schlessera merged 2 commits into
wp-cli:masterwp-cli/wp-cli:masterfrom
wpamitkumar:fix-typos-and-docs-standardswpamitkumar/wp-cli:fix-typos-and-docs-standardsCopy head branch name to clipboard
Feb 5, 2020
Merged

Fix typos and docs standards and URL.#5337
schlessera merged 2 commits into
wp-cli:masterwp-cli/wp-cli:masterfrom
wpamitkumar:fix-typos-and-docs-standardswpamitkumar/wp-cli:fix-typos-and-docs-standardsCopy head branch name to clipboard

Conversation

@wpamitkumar

Copy link
Copy Markdown
Contributor
  • fix typos and docs standards and URL.

@wpamitkumar wpamitkumar requested a review from a team as a code owner January 20, 2020 12:50
Comment thread php/utils.php Outdated
* Composes positional arguments into a command string.
*
* @param array
* @param array $args Composes positional arguments.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @param array $args Composes positional arguments.
* @param array $args Positional arguments to compose.

Comment thread php/utils.php Outdated
* Composes associative arguments into a command string.
*
* @param array
* @param array $assoc_args Composes associative arguments.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @param array $assoc_args Composes associative arguments.
* @param array $assoc_args Associative arguments to compose.

Comment thread php/utils.php Outdated
@@ -559,11 +560,11 @@ function make_progress_bar( $message, $count, $interval = 100 ) {
* Additionally, this adds 'http://' to the URL if no scheme was found.
*
* @param string $url The URL to parse.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alignment is off for this comment block.

@wpamitkumar wpamitkumar Jan 29, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alignment is the same at is.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image 2020-01-29 at 8 29 12 AM

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue fixed.

@schlessera schlessera added the scope:documentation Related to documentation label Feb 5, 2020
@schlessera schlessera added this to the 2.5.0 milestone Feb 5, 2020
@schlessera schlessera merged commit 5dc1c58 into wp-cli:master Feb 5, 2020
@schlessera schlessera changed the title fix typos and docs standards and URL. Fix typos and docs standards and URL. Feb 5, 2020
@schlessera

Copy link
Copy Markdown
Member

Thanks for the PR, @wpamitkumar !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:documentation Related to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.