Merged
Conversation
Phive needs a GPG signature as `.phar.asc` file. See https://phar.io/howto/sign-and-upload-to-github.html
Member
Author
|
This will probably not work as is, as GitHub/Travis does not have my private GPG key, GitHub only has the public one. The private key is needed to sign something, however. For a proper solution: https://stackoverflow.com/questions/45188811/how-to-gpg-sign-a-file-that-is-built-by-travis-ci |
Contributor
|
So leave this for now and do manually as you suggest on slack some time after release? |
miya0001
approved these changes
Feb 1, 2018
Member
Author
|
@miya0001 This was not meant to be merged, as it will not work. GPG does not have a corresponding private key on the Travis side. |
Member
Author
|
Discussion should happen here: #4659 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phive needs a GPG signature as
.phar.ascfile.See https://phar.io/howto/sign-and-upload-to-github.html