Incorrect table column width calculcations with colorized strings.#4249
Merged
danielbachhuber merged 4 commits intoJul 26, 2017
wp-cli:masterwp-cli/wp-cli:masterfrom
gitlost:issue_php_cli_tools_106gitlost/wp-cli:issue_php_cli_tools_106Copy head branch name to clipboard
Merged
Incorrect table column width calculcations with colorized strings.#4249danielbachhuber merged 4 commits intowp-cli:masterwp-cli/wp-cli:masterfrom gitlost:issue_php_cli_tools_106gitlost/wp-cli:issue_php_cli_tools_106Copy head branch name to clipboard
danielbachhuber merged 4 commits into
wp-cli:masterwp-cli/wp-cli:masterfrom
gitlost:issue_php_cli_tools_106gitlost/wp-cli:issue_php_cli_tools_106Copy head branch name to clipboard
Conversation
danielbachhuber
approved these changes
Jul 26, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue wp-cli/php-cli-tools#106
This uses the pre-colorized stuff added in wp-cli/php-cli-tools#111. Adds
ascii_pre_colorizedarg to the various display functions inFormatterwhich eventually gets passed toshow_table()which just callsTable::setAsciiPreColorized()with it.So if you have an Ascii table with some pre-colorized columns you can do eg
$table->display_items( $items, array( true, false, true ) )to indicate that the padding should be adjusted for them.