Use a more impossible placeholder pattern in Colors::colorize()#93
Merged
danielbachhuber merged 2 commits intoJan 1, 2016
masterwp-cli/php-cli-tools:masterfrom
placeholder-character-colorizewp-cli/php-cli-tools:placeholder-character-colorizeCopy head branch name to clipboard
Merged
Use a more impossible placeholder pattern in Colors::colorize()#93danielbachhuber merged 2 commits intomasterwp-cli/php-cli-tools:masterfrom placeholder-character-colorizewp-cli/php-cli-tools:placeholder-character-colorizeCopy head branch name to clipboard
Colors::colorize()#93danielbachhuber merged 2 commits into
masterwp-cli/php-cli-tools:masterfrom
placeholder-character-colorizewp-cli/php-cli-tools:placeholder-character-colorizeCopy head branch name to clipboard
Conversation
This prevents true percent + space combinations from losing the space.
danielbachhuber
added a commit
that referenced
this pull request
Jan 1, 2016
Use a more impossible placeholder pattern in `Colors::colorize()`
danielbachhuber
added a commit
to wp-cli/wp-cli
that referenced
this pull request
Jan 1, 2016
jghazally
pushed a commit
to jghazally/wp-cli
that referenced
this pull request
Feb 23, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents true percent + space combinations from losing the space.
Reported in wp-cli/wp-cli#1736