Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Verifies if exec is not in disable_functions directive#83

Merged
danielbachhuber merged 2 commits into
wp-cli:masterwp-cli/php-cli-tools:masterfrom
tiagohillebrandt:mastertiagohillebrandt/php-cli-tools:masterCopy head branch name to clipboard
Aug 10, 2015
Merged

Verifies if exec is not in disable_functions directive#83
danielbachhuber merged 2 commits into
wp-cli:masterwp-cli/php-cli-tools:masterfrom
tiagohillebrandt:mastertiagohillebrandt/php-cli-tools:masterCopy head branch name to clipboard

Conversation

@tiagohillebrandt

Copy link
Copy Markdown
Contributor

This patch fixes the warning displayed when exec is set in disable_functions directive.

Warning: exec() has been disabled for security reasons in vendor/wp-cli/php-cli-tools/lib/cli/Shell.php on line 32

If exec is disabled, $columns will assume the value set here: https://github.com/tiagohillebrandt/php-cli-tools/blob/master/lib/cli/Shell.php#L44,L46

@danielbachhuber danielbachhuber added this to the v0.10.5 milestone Aug 10, 2015
danielbachhuber pushed a commit that referenced this pull request Aug 10, 2015
Verifies if exec is not in disable_functions directive
@danielbachhuber danielbachhuber merged commit 037a010 into wp-cli:master Aug 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.