Fix the static variable in the Lexer + fix option populating to default ...#79
Merged
danielbachhuber merged 1 commit intoFeb 27, 2015
wp-cli:masterwp-cli/php-cli-tools:masterfrom
rantonmattei:2015-02-26--Default-option-valuerantonmattei/php-cli-tools:2015-02-26--Default-option-valueCopy head branch name to clipboard
Merged
Fix the static variable in the Lexer + fix option populating to default ...#79danielbachhuber merged 1 commit intowp-cli:masterwp-cli/php-cli-tools:masterfrom rantonmattei:2015-02-26--Default-option-valuerantonmattei/php-cli-tools:2015-02-26--Default-option-valueCopy head branch name to clipboard
danielbachhuber merged 1 commit into
wp-cli:masterwp-cli/php-cli-tools:masterfrom
rantonmattei:2015-02-26--Default-option-valuerantonmattei/php-cli-tools:2015-02-26--Default-option-valueCopy head branch name to clipboard
Conversation
…lt when no value provided
This was referenced Feb 27, 2015
danielbachhuber
added a commit
that referenced
this pull request
Feb 27, 2015
…alue Fix the static variable in the Lexer + fix option populating to default ...
Author
|
Hi @danielbachhuber, do you know when I can expect a new tag along with a new version available on Packagist? |
Member
|
Sorry for the delay — just pushed. |
Author
|
No worries. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...when no value provided.
Fixed the option set to the default value when no value was provided and that the option settings had a
defaultsetup. (see issue #30)Tests have been added for that scenario.
I had to fix the static var issue because of the penultimate test. It was triggering an exception (looks like PhpUnit catches E_USER_WARNING errors and change them to exceptions...), therefore it never got to the
Lexer::$allowRewind = true;line and caused the following and last test to fail. I reused the fix from PR #55 which was much cleaner. You can close that PR BTW.@danielbachhuber please review