Fixed incorrect lengths for colorized strings in ASCII table#69
Merged
danielbachhuber merged 2 commits intoNov 12, 2014
wp-cli:masterwp-cli/php-cli-tools:masterfrom
arm4b:bug/colorized-strings-in-ascii-tableCopy head branch name to clipboard
Merged
Fixed incorrect lengths for colorized strings in ASCII table#69danielbachhuber merged 2 commits intowp-cli:masterwp-cli/php-cli-tools:masterfrom arm4b:bug/colorized-strings-in-ascii-tableCopy head branch name to clipboard
danielbachhuber merged 2 commits into
wp-cli:masterwp-cli/php-cli-tools:masterfrom
arm4b:bug/colorized-strings-in-ascii-tableCopy head branch name to clipboard
Conversation
Author
|
@danielbachhuber it's fixed I think.
I've added more unit tests also for this special case. |
danielbachhuber
added a commit
that referenced
this pull request
Nov 12, 2014
Fixed incorrect lengths for colorized strings in ASCII table
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #59
Bug looks this way:
I've added failing test for this case, but couldn't find the reason yet.
Will try to check later also.