Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix table padding for accented characters#53

Merged
danielbachhuber merged 2 commits into
masterwp-cli/php-cli-tools:masterfrom
fix-53wp-cli/php-cli-tools:fix-53Copy head branch name to clipboard
Jun 29, 2014
Merged

Fix table padding for accented characters#53
danielbachhuber merged 2 commits into
masterwp-cli/php-cli-tools:masterfrom
fix-53wp-cli/php-cli-tools:fix-53Copy head branch name to clipboard

Conversation

@danielbachhuber

@danielbachhuber danielbachhuber commented Jun 29, 2014

Copy link
Copy Markdown
Member

Is it misaligned because of the accented characters?

| fv_clean_trash_hourly               | 2014-05-23 16:57:53 | 44 minutes 21 seconds | 1 óra               |
| qs_cron_hook                        | 2014-05-23 17:12:05 | 58 minutes 33 seconds | 1 óra               |
| wp_maybe_auto_update                | 2014-05-23 18:06:00 | 1 óra 52 minutes     | 12 óra              |
| wp_scheduled_delete                 | 2014-05-23 19:07:38 | 2 óra 54 minutes     | 1 nap                |
| alo_em_schedule                     | 2014-05-23 19:40:22 | 3 óra 26 minutes     | 12 óra              |

@szepeviktor

szepeviktor commented May 23, 2014

Copy link
Copy Markdown
Author 
php -r 'echo strlen("óra");'
4
php -r 'echo mb_strlen("óra", "UTF-8");'
3

https://github.com/jlogsdon/php-cli-tools/blob/master/lib/cli/Colors.php#L181

@szepeviktor

szepeviktor commented May 23, 2014

Copy link
Copy Markdown
Author

wp-cli/wp-cli#1219

@szepeviktor

szepeviktor commented Jun 20, 2014

Copy link
Copy Markdown
Author

Is there any update on this?

@danielbachhuber danielbachhuber added this to the 0.9.5 milestone Jun 29, 2014
@danielbachhuber
An encoding-safe way of getting string length.
7b3d157 
Introduces tests to the project.
@danielbachhuber danielbachhuber changed the title table padding Fix table padding for accented characters Jun 29, 2014
danielbachhuber added a commit that referenced this pull request Jun 29, 2014
@danielbachhuber
Merge pull request #53 from wp-cli/fix-53
48bb9ad 
Fix table padding for accented characters
@danielbachhuber danielbachhuber merged commit 48bb9ad into master Jun 29, 2014
@danielbachhuber danielbachhuber deleted the fix-53 branch June 29, 2014 19:54
@szepeviktor

szepeviktor commented Jun 29, 2014

Copy link
Copy Markdown
Author

Thank you!

This was referenced Aug 3, 2014
Closed
Closed
@scribu scribu mentioned this pull request Sep 5, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.5

Development

Successfully merging this pull request may close these issues.

2 participants

@danielbachhuber @szepeviktor
Morty Proxy This is a proxified and sanitized view of the page, visit original site.